Exclude PIE ports from buffer and qos config #21036
Conversation
Signed-off-by: Zhixin Zhu <[email protected]>
zhixzhu
changed the title
| @@ -115,6 +115,7 @@ def | |||
| {%- set PORT_BP = [] %} | |||
| {%- set PORT_DPC = [] %} | |||
| {%- set SYSTEM_PORT_ALL = [] %} | |||
| {%- set PORT_PIE = [] %} | |||
There was a problem hiding this comment.
Instead of PIE ports, can we have something like QOS_BYPASS_INTERNAL_PORT in a generic way? This can be repurposed for other use cases.
There was a problem hiding this comment.
Changed it to PORT_QOS_BYPASS which is more generic.
Signed-off-by: Zhixin Zhu <[email protected]>
|
@kperumalbfn I have updated PR to resolve comments. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Exclude pie ports from buffer and qos config Signed-off-by: Zhixin Zhu <[email protected]>
|
@kperumalbfn could you help add label to cherry-pick to 202405 and 202411? |
|
Cherry-pick PR to 202411: #21747 |
Hi @zhixzhu, what's the impact if this change is missing? |
@bingwang-ms PIE port doesn't support buffer and qos config, it will cause some SAI failure and syncd down if trying to config it. |
|
Is this change only required for Chassis? |
@bingwang-ms It is for 8122, not chassis. |
Exclude pie ports from buffer and qos config Signed-off-by: Zhixin Zhu <[email protected]>
Exclude pie ports from buffer and qos config Signed-off-by: Zhixin Zhu <[email protected]>
Why I did it
PIE ports are used for internal traffic (telemetry), not for regular data traffic, doesn't support buffer or qos config.
Work item tracking
How I did it
Exclude PIE ports from PORTS_ACTIVE.
How to verify it
config load_minigraph.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)