[updategraph] Don't reuse init_cfg.json from old image during upgrade #2036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Sep 12, 2018
lguohan
pushed a commit
that referenced
this pull request
Sep 12, 2018
theasianpianist
added a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Sep 2, 2022
Include following commits: 414e239 update unit tests for swap allocator a91a492 consider swap checking memory in installer f0ce586 [route_check]: Ignore standalone tunnel routes (sonic-net#2325) 3af8ba4 Replace cmp in acl_loader with operator.eq (sonic-net#2328) 899ba12 Subinterface vrf bind issue fix (sonic-net#2211) e45b47a [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands (sonic-net#2333) f82835e [doc]: Add MACsec CLI doc (sonic-net#2334) 666bdc0 [sonic-package-manager] Drop 'expires_in' (sonic-net#2002) 52ac8ac Handle non-front-panel ports in is_rj45_port (sonic-net#2327) 42ed6d5 [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (sonic-net#2319) d1a2d72 correct an error by changing "show bgp summary" to "show bfd summary" (sonic-net#2324) 7d409a0 Update VRF unbind command (sonic-net#2331) e14f679 Fix issue: port_type is referenced before initialized (sonic-net#2323) 7704f63 Fix issue: exception in is_rj45_port in multi ASIC env (sonic-net#2313) 6fc4f15 Delete .DS_Store (sonic-net#2244) ece4049 Fix bug with checking VRF's routes in route_check.py (sonic-net#2301) 20c6d18 [decode-syseeprom] Fix setting use_db based on support_eeprom_db (sonic-net#2270) 9282e6c Fix vrf UT failed issue (sonic-net#2309) 37eb2b3 add lacp_rate to portchannel (sonic-net#2036) Signed-off-by: Lawrence Lee <[email protected]>
liat-grozovik
pushed a commit
that referenced
this pull request
Sep 4, 2022
Update sonic-utilities submodule pointer to include the following: Replace cmp in acl_loader with operator.eq (#2328) Subinterface vrf bind issue fix (#2211) [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands (#2333) [doc]: Add MACsec CLI doc (#2334) [sonic-package-manager] Drop 'expires_in' (#2002) Handle non-front-panel ports in is_rj45_port (#2327) [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (#2319) correct an error by changing "show bgp summary" to "show bfd summary" (#2324) Update VRF unbind command (#2331) Fix issue: port_type is referenced before initialized (#2323) Fix issue: exception in is_rj45_port in multi ASIC env (#2313) Delete .DS_Store (#2244) Fix bug with checking VRF's routes in route_check.py (#2301) [decode-syseeprom] Fix setting use_db based on support_eeprom_db (#2270) Fix vrf UT failed issue (#2309) add lacp_rate to portchannel (#2036)
vadymhlushko-mlnx
pushed a commit
to vadymhlushko-mlnx/sonic-buildimage
that referenced
this pull request
Nov 11, 2022
#### What I did Make lacp_rate configurable for portchannel. ``` Option specifying the rate in which we'll ask our link partner to transmit LACPDU packets in 802.3ad mode. Possible values are: slow Request partner to transmit LACPDUs every 30 seconds fast Request partner to transmit LACPDUs every 1 second The default is slow. ``` #### Why I did it In case of slow lacp_rate configuration link down will be detected in 60-90 seconds, it may be to long (for example for MCLAG high availability), in case of using ` --fast-rate=true` link down will be detected in 2-3 seconds. #### How I did it * add optional argument to `config portchannel` command, default=slow for backward compatibility. (this PR) * parse argument in `teammgr` and forward it to `teamd` (other PR: sonic-net/sonic-swss#2121) * update docs sonic-net/SONiC#937 #### How to verify it Confgiure bond on other side, then configure portchannel and sniff the traffic from it. ``` config portchannel add PortChannel0001 --fast-rate=true config portchannel member add PortChannel0001 Ethernet0 config interface ip add PortChannel0001 192.168.1.2/24 tcpdump -ne ```
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
During sonic upgrade, use init_cfg.json from new image instead of reusing the one from old version.