Skip to content

[ntp] Add support for ntp to listen ipv4/ipv6 address depends on server config #20227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

yaqiangz
Copy link
Contributor

@yaqiangz yaqiangz commented Sep 11, 2024

Why I did it

Switch cannot connect to NTP server with Loopback ipv6 in Loopback ipv6 only scenario.

Work item tracking
  • Microsoft ADO (number only): 29415265

How I did it

Add support for ntp to listen ipv4/ipv6 address depends on server config

How to verify it

Run ntp test with new template

generic_config_updater/test_ntp.py::test_ntp_server_tc1_suite PASSED                                                                                                                                                                                                                                                          [100%]
ntp/test_ntp.py::test_ntp_long_jump_enabled[False] PASSED                                                                                                                                                                                                                                                                     [ 16%]
ntp/test_ntp.py::test_ntp_long_jump_disabled[False] PASSED                                                                                                                                                                                                                                                                    [ 33%]
ntp/test_ntp.py::test_ntp[False] PASSED                                                                                                                                                                                                                                                                                       [ 50%]
ntp/test_ntp.py::test_ntp_long_jump_enabled[True] PASSED                                                                                                                                                                                                                                                                      [ 66%]
ntp/test_ntp.py::test_ntp_long_jump_disabled[True] PASSED                                                                                                                                                                                                                                                                     [ 83%]
ntp/test_ntp.py::test_ntp[True] PASSED                                                                                                                                                                                                                                                                                        [100%]

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@yaqiangz yaqiangz changed the title [ntp] Add support for ntp to listen ipv4/ipv6 address depends on serv… [ntp] Add support for ntp to listen ipv4/ipv6 address depends on server config Sep 12, 2024
@yaqiangz yaqiangz marked this pull request as ready for review September 12, 2024 03:37
@yaqiangz yaqiangz requested a review from lguohan as a code owner September 12, 2024 03:37
@yaqiangz
Copy link
Contributor Author

Hi @yxieca could you please help to merge this PR?

@yxieca yxieca merged commit 87282ed into sonic-net:master Sep 13, 2024
23 checks passed
@yaqiangz
Copy link
Contributor Author

Hi @bingwang-ms could you please help to approve the backport request?

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 19, 2024
…er config (sonic-net#20227)

Why I did it
Switch cannot connect to NTP server with Loopback ipv6 in Loopback ipv6 only scenario.

Work item tracking
Microsoft ADO (number only): 29415265

How I did it
Add support for ntp to listen ipv4/ipv6 address depends on server config

How to verify it
Run ntp test with new template
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #20303

mssonicbld pushed a commit that referenced this pull request Sep 20, 2024
…er config (#20227)

Why I did it
Switch cannot connect to NTP server with Loopback ipv6 in Loopback ipv6 only scenario.

Work item tracking
Microsoft ADO (number only): 29415265

How I did it
Add support for ntp to listen ipv4/ipv6 address depends on server config

How to verify it
Run ntp test with new template
yanjundeng pushed a commit to yanjundeng/sonic-buildimage that referenced this pull request Apr 23, 2025
…er config (sonic-net#20227)

Why I did it
Switch cannot connect to NTP server with Loopback ipv6 in Loopback ipv6 only scenario.

Work item tracking
Microsoft ADO (number only): 29415265

How I did it
Add support for ntp to listen ipv4/ipv6 address depends on server config

How to verify it
Run ntp test with new template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants