[dhcp_server] Fix dhcp_server mk file mistake #19847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
This reverts commit 88f0356.
yaqiangz
changed the title
Blueve
approved these changes
Aug 7, 2024
|
Hi @yxieca could you please help to merge this PR? |
|
Hi @bingwang-ms could you please help to approve the backport request? |
1 similar comment
|
Hi @bingwang-ms could you please help to approve the backport request? |
matiAlfaro
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Aug 21, 2024
* [dhcp_server] Fix dhcp_serverer mk file mistake * Set include_dhcp_server to y * Revert "Set include_dhcp_server to y" This reverts commit 88f0356.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 23, 2024
* [dhcp_server] Fix dhcp_serverer mk file mistake * Set include_dhcp_server to y * Revert "Set include_dhcp_server to y" This reverts commit 88f0356.
|
Cherry-pick PR to 202405: #20004 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 26, 2024
* [dhcp_server] Fix dhcp_serverer mk file mistake * Set include_dhcp_server to y * Revert "Set include_dhcp_server to y" This reverts commit 88f0356.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
* [dhcp_server] Fix dhcp_serverer mk file mistake * Set include_dhcp_server to y * Revert "Set include_dhcp_server to y" This reverts commit 88f0356.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Startup dependency is missing for dhcp_server, which would cause that it startup before swss.
Work item tracking
How I did it
Fix the startup missing issue
How to verify it
Build image and install to check
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)