-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[buildimage] Add support for PoE feature #19636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? does PoE syncd have any interaction with "regular" (npu) syncd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syncd is needed for interraction between PoE hardware (PSE) and SAI APIs to synchronize state changes from application and control plane with PSE.
Also syncd contains serialization for PoE specific attribute types (e.g. sai_poe_port_power_consumption_t in function sai_serialize_poe_port_power_consumption()).
e13c21c
to
a4c41d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we split PR into smaller ones? at least YANG model could be dedicated one.
yes, I'll move the changes to yang models to a new PR |
a4c41d2
to
e1fafd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pump up this thread. @reviewers, can you please help to review the related code PRs? Thanks. |
Add target for poesyncd container Add poe_vs hwsku Add build flag to disable PoE feature (enabled by default). Add cleanup of PoE database during config reload. Signed-off-by: Serhiy Boiko <[email protected]> Change-Id: I2f2b8d7ed3285193b1d58b9fc666dcb8bf1bfcd9
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
This feature was reviewed by PENS workgroup. How we can move forward merging it? @lguohan @qiluo-msft @xumia |
Why I did it
To add PoE capabilities to SONiC
Work item tracking
How I did it
Support for the PoE feature relies on changes in multiple repositories:
HLD: sonic-net/SONiC#1631
Changes in this PR include:
poe_vs
hwsku (which is based on Force10-S6000)How to verify it
Run in a vs build:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)