-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update Arista7060X6-PE 256x200G mmu configuration. #19570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
"size": "165660324", | ||
"type": "ingress", | ||
"mode": "dynamic", | ||
"xoff": "25489408" | ||
"xoff": "29520896" | ||
}, | ||
"egress_lossless_pool": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we just say this is egress_pool? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i do not know if other repo (swss/sonic-utilitie) make any assumption on the name, we need to check that. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, things like qos tests are currently assuming the name while grabing the configuration, changing the name will cause these tests to break at this moment... |
||
"size": "165660324", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these values should now be reverted back to reflect the production bcm config, e.g.
121964196
hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not all numbers, these values are the latest recommended ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b62e111#diff-38141bc38cf22f25e51d1afa26023349fcb218e27d0c46e8ada19c6c9081111cL2251-L2252
I'm not sure how
165660324
was derived in the second commit, but I believe this change to the SHARED_LIMIT_CELLS needs to be reflected? (240087 * 254 * 2 = 121964196)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are aligned from calculation perspective, however if you check the sai api values that shared by broadcom. the value is indeed this....