-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[build] Fix bookworm reproducible build issue. #18789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xumia , kvmtest-t0 is a known issue. Please ignore. |
Bypass the known test case failure to fix build broken issue. |
I got this error message for sonic-slave-bookworm container:
Maybe you should use |
Oh.
It needs tests. Maybe some scenario reports the error. The PR fixed build issue at that time. I'm not sure if adding sudo have other issues. |
@liushilongbuaa FYI When we enable or disable reproducible mirrors in this function we use
That's why my suggestion was to also use $SUDO when mv sources.list. But I haven't tested this. |
This commit resolves a permission denied issue during the mv command in bookworm by adding escalated sudo privileges. For more details, see the related PR and discussion: sonic-net#18789 Signed-off-by: Matej Feder <[email protected]>
This commit resolves a permission denied issue during the mv command in bookworm by adding escalated sudo privileges. For more details, see the related PR and discussion: sonic-net/sonic-buildimage#18789 Signed-off-by: Matej Feder <[email protected]>
Why I did it
Bookworm involved new file /etc/apt/sources.list.d/debian.sources to setup debian mirror repo.
Reproducible build need to support this scenario.
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)