Supports FRR-VRRP configuration #18617
Conversation
Signed-off-by: philo <[email protected]>
Signed-off-by: philo <[email protected]>
Signed-off-by: philo <[email protected]>
…28-support-vrrp6-commands-and-tracking-interface.patch
…30-support-vrrp6-commands-and-tracking-interface.patch
Signed-off-by: philo <[email protected]>
Signed-off-by: philo <[email protected]>
| PROXY_SERVER_ADDR = '/etc/frr/vrrpd_client_sock' | ||
| ALL_DAEMONS = ['vrrpd'] | ||
| TABLE_DAEMON = { | ||
| 'VRRP': ['vrrpd'], |
There was a problem hiding this comment.
I believe, we discussed to have VRRP config handler for FRR as part of frrcfgd itself, what are we doing here?
There was a problem hiding this comment.
Yes, we have also implemented this functionality in frrcfgd. This provides an alternative for usage when frrcfgd is not enabled. Some users may need to use it this way.
There was a problem hiding this comment.
vrrcfgd is totally a duplicate code, I would like to better understand in which case vrrpcfgd will be enabled but not frrcfgd. Keeping both the code will be hard to manage, I would recommend using frrcfgd only for VRRP feature.
There was a problem hiding this comment.
vrrcfgd is totally a duplicate code, I would like to better understand in which case vrrpcfgd will be enabled but not frrcfgd. Keeping both the code will be hard to manage, I would recommend using frrcfgd only for VRRP feature.
OK, vrrpcfgd has been removed, thanks.
…54-support-vrrp6-commands-and-tracking-interface.patch
Signed-off-by: philo <[email protected]>
|
@philo-micas As per the HLD, I am unable to find the changes related to vrrpsyncd and vrrporch in any of your PRs. Can you please point me to the respective PR? |
Signed-off-by: philo <[email protected]>
|
@vvbrcm @madhupalu please help review |
|
Please check the CPU utilisation of frrcfgd when VRRP is enabled. I found it to be constant to 100%. |
src/sonic-frr/patch/0054-support-vrrp6-commands-and-tracking-interface.patch
Outdated
Show resolved
Hide resolved
Signed-off-by: philo <[email protected]>
|
/azp run Azure.sonic-buildimage |
|
Pull request contains merge conflicts. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…81-support-vrrp6-commands-and-tracking-interface.patch
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
1 similar comment
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@philo-micas , thanks for adding this feature. Will this make to 202505 release? Please let me know the release that this feature is planned for. |
|
@praveenraja1，I'm still trying to push this towards merge, ideally in the 202505 release. For example, this PR has encountered some vstest issues that I'm still working on resolving. |
…84-support-vrrp6-commands-and-tracking-interface.patch
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Why I did it
Work item tracking
How I did it
hld:sonic-net/SONiC#1446
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)