-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[yang] Restrict AAA authorization with TACPLUS passkey #18155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ganglyu
approved these changes
Feb 23, 2024
liuh-80
approved these changes
Feb 23, 2024
qiluo-msft
approved these changes
Feb 23, 2024
qiluo-msft
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Feb 23, 2024
## Description of PR ADO: 26898399 Summary: Update testcase per YANG model change in AAA Fixes # (issue) ## Approach #### What is the motivation for this PR? Update test due to recent AAA YANG model change. sonic-net/sonic-buildimage#18155 #### How did you do it? Add relative restriction #### How did you verify/test it? E2E test
/azp run Azure.sonic-buildimage |
Commenter does not have sufficient privileges for PR 18155 in repo sonic-net/sonic-buildimage |
/azp run |
Commenter does not have sufficient privileges for PR 18155 in repo sonic-net/sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Commenter does not have sufficient privileges for PR 18155 in repo sonic-net/sonic-buildimage |
sonic-otn
pushed a commit
to Weitang-Zheng/sonic-buildimage
that referenced
this pull request
Mar 11, 2024
### Why I did it Command cannot be executed when tacacs+ in AAA authorization is set and passkey in TACPLUs is not set. There should be such restriction in YANG model definition. ##### Work item tracking - Microsoft ADO **(number only)**: 26898399 #### How I did it Add restirction #### How to verify it unit test
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
### Why I did it Command cannot be executed when tacacs+ in AAA authorization is set and passkey in TACPLUs is not set. There should be such restriction in YANG model definition. ##### Work item tracking - Microsoft ADO **(number only)**: 26898399 #### How I did it Add restirction #### How to verify it unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Command cannot be executed when tacacs+ in AAA authorization is set and passkey in TACPLUs is not set. There should be such restriction in YANG model definition.
Work item tracking
How I did it
Add restirction
How to verify it
unit test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)