[Mellanox] Add N/A as a valid fan direction for Nvidia platforms #17930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
keboliu
reviewed
Jan 29, 2024
| @@ -46,9 +46,11 @@ | |||
| FAN_DIR = "/var/run/hw-management/thermal/fan{}_dir" | |||
| FAN_DIR_VALUE_EXHAUST = 0 | |||
| FAN_DIR_VALUE_INTAKE = 1 | |||
| FAN_DIR_VALUE_NOT_APPLICABLE = 2 | |||
There was a problem hiding this comment.
which one will be better, 'N/A' or 'UNKNOWN'?
There was a problem hiding this comment.
The schema values support 'N/A', and also the 'FanBase' interface refers to this value as not applicable. So I think the 'N/A' value is better.
keboliu
approved these changes
Jan 30, 2024
liat-grozovik
changed the title
liat-grozovik
approved these changes
Feb 19, 2024
sonic-otn
pushed a commit
to Weitang-Zheng/sonic-buildimage
that referenced
this pull request
Mar 11, 2024
…ic-net#17930) - Why I did it On some Nvidia platforms, fan direction could not be determined. Therefore 'N/A' becomes a valid value for those cases. - How I did it Add 'N/A' to the valid fan direction mapping, to avoid an error in the log. - How to verify it Check fan direction on Nvidia platforms, and make sure there aren't errors in the log.
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
…ic-net#17930) - Why I did it On some Nvidia platforms, fan direction could not be determined. Therefore 'N/A' becomes a valid value for those cases. - How I did it Add 'N/A' to the valid fan direction mapping, to avoid an error in the log. - How to verify it Check fan direction on Nvidia platforms, and make sure there aren't errors in the log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
On some Nvidia platforms, fan direction could not be determined. Therefore 'N/A' becomes a valid value for those cases.
Work item tracking
How I did it
Add 'N/A' to the valid fan direction mapping, to avoid an error in the log.
How to verify it
Check fan direction on Nvidia platforms, and make sure there aren't errors in the log.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)