[dhcp_server] Remove dependency in port-name-alias-map.txt.j2 #17858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaqiangz
force-pushed
the
master_dhcp_server_port_alias
branch
from
c031bdd to
bd179fa
Compare
yaqiangz
commented
Jan 21, 2024
Blueve
approved these changes
Jan 22, 2024
|
@yxieca Could you please help to merge this PR? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 2, 2024
…net#17858) * [dhcp_server] Remove dependency in port-name-alias-map.txt.j2
|
Cherry-pick PR to 202311: #17995 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 2, 2024
* [dhcp_server] Remove dependency in port-name-alias-map.txt.j2
rajib-dutta1
pushed a commit
to rajib-dutta1/sonic-buildimage
that referenced
this pull request
Feb 13, 2024
…net#17858) * [dhcp_server] Remove dependency in port-name-alias-map.txt.j2
yxieca
added
Included in 202311 Branch
and removed
Approved for 202311 Branch
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Currently dhcp_cfggen gets port map from file port-name-alias-map.txt, which is actually generated refer to CONFIG_DB. It will encounter error when PORTCHANNEL table or PORT table not exist in CONFIG_DB.
Work item tracking
How I did it
Modify dhcp_cfggen to get port map from CONFIG_DB directly.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)