[docker-databse]: Revise database_global schema for DPU #17443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove databse_type 2. Add a new field databse_name Signed-off-by: Ze Gan <[email protected]>
qiluo-msft
approved these changes
Dec 7, 2023
ganglyu
approved these changes
Dec 8, 2023
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
approved these changes
Dec 19, 2023
qiluo-msft
reviewed
Jan 11, 2024
| @@ -26,7 +26,7 @@ | |||
| {% if dpu_cnt > 0 %} | |||
| {% for dpu in range(dpu_cnt) %} | |||
| { | |||
| "database_type" : "dpudb", | |||
| "database_name" : "dpu{{dpu}}", | |||
There was a problem hiding this comment.
Sorry for late comment. "database" will be ambigous terminology since there are multiple databases inside one Redis instance. How about "container_name"
qiluo-msft
pushed a commit
to sonic-net/sonic-swss-common
that referenced
this pull request
Jan 27, 2024
This PR is for expanding the capability of dbconnect to adapt the new DPU DB schema introduced by PR: sonic-net/sonic-buildimage#17443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Revise DPU's database_global.json schema to achieve a more general design
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)