[docker-database-init.sh]:Fix wrong creating of database_global.json in multi asic platform #17221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pterosaur
changed the title
Pterosaur
force-pushed
the
fix_multi_asic_database_global
branch
2 times, most recently
from
e694f23 to
848cab5
Compare
Signed-off-by: Ze Gan <[email protected]>
Pterosaur
force-pushed
the
fix_multi_asic_database_global
branch
from
848cab5 to
bf36068
Compare
11 tasks
|
/azpw ms_conflict |
lguohan
approved these changes
Nov 20, 2023
|
@judyjoseph , can you check? |
judyjoseph
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix bug: #17161 (comment)
multi-asic platforms it will never go to the else part as DATABASE_TYPE is always ""
Work item tracking
How I did it
Move the checker
NAMESPACE_ID == ""backHow to verify it
Check Azp
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)