[build] use pigz by default #16959
Merged
[build] use pigz by default #16959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
previously approved these changes
Nov 16, 2023
k-v1
force-pushed
the
use_pigz_by_default
branch
from
3013e08 to
ba14623
Compare
|
Fixed for bookworm. |
11 tasks
k-v1
force-pushed
the
use_pigz_by_default
branch
from
ba14623 to
c1577f3
Compare
|
Rebased and fixed merge conflict. |
11 tasks
lguohan
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
pigz, which stands for parallel implementation of gzip,is a fully functional replacement for gzip that exploits multiple processors
and multiple cores to the hilt when compressing data.
We can use it for compression instead of gzip to speed up builds.
It reduces build time (especially at final stage where we compress whole file system).
But solution with special option
GZ_COMPRESS_PROGRAMis not good,because it's hard to maintain (developers need to pass this flag to every script).
I think it's better to remove this option at all and use pigz directly where it's possible.
Work item tracking
How I did it
Remove config flag
GZ_COMPRESS_PROGRAMUse pigz directly instead of gzip where it's possible.
How to verify it
I have tested builds with pigz almost 1 year and no issues were detected.
So I think it's better to enable it by default for all builds.
If we found some issues we can always replace pigz with gzip.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)