[fast-reboot] Fix regression: set state_db flag to support fast-reboot from older images #16733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t fast-reboot from older images
11 tasks
vaibhavhd
added
Request for 202111 Branch
yxieca
approved these changes
Sep 27, 2023
stepanblyschak
approved these changes
Sep 28, 2023
|
Please do not merge this PR until manual verification is completed on the master and cherry pick branches. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 28, 2023
…t fast-reboot from older images (sonic-net#16733) Why I did it Fix: sonic-net#16699 Fast reboot is failing from old OS versions (eg., 201911 image) to latest (eg., master branch) after PR sonic-net#15685 The system wide flag for FAST_REBOOT is still required when the base OS version does not support the new fast-reboot reconciliation logic (no db dump)
|
Cherry-pick PR to 202305: #16753 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 28, 2023
…t fast-reboot from older images (sonic-net#16733) Why I did it Fix: sonic-net#16699 Fast reboot is failing from old OS versions (eg., 201911 image) to latest (eg., master branch) after PR sonic-net#15685 The system wide flag for FAST_REBOOT is still required when the base OS version does not support the new fast-reboot reconciliation logic (no db dump)
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 28, 2023
…t fast-reboot from older images (sonic-net#16733) Why I did it Fix: sonic-net#16699 Fast reboot is failing from old OS versions (eg., 201911 image) to latest (eg., master branch) after PR sonic-net#15685 The system wide flag for FAST_REBOOT is still required when the base OS version does not support the new fast-reboot reconciliation logic (no db dump)
|
Cherry-pick PR to 202205: #16754 |
|
Cherry-pick PR to 202211: #16755 |
This was referenced Sep 28, 2023
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
|
@vaibhavhd cherry pick PR didn't pass PR checker. Please check!!! |
7 similar comments
|
@vaibhavhd cherry pick PR didn't pass PR checker. Please check!!! |
|
@vaibhavhd cherry pick PR didn't pass PR checker. Please check!!! |
|
@vaibhavhd cherry pick PR didn't pass PR checker. Please check!!! |
|
@vaibhavhd cherry pick PR didn't pass PR checker. Please check!!! |
|
@vaibhavhd cherry pick PR didn't pass PR checker. Please check!!! |
|
@vaibhavhd cherry pick PR didn't pass PR checker. Please check!!! |
|
@vaibhavhd cherry pick PR didn't pass PR checker. Please check!!! |
mssonicbld
pushed a commit
that referenced
this pull request
Oct 20, 2023
…t fast-reboot from older images (#16733) Why I did it Fix: #16699 Fast reboot is failing from old OS versions (eg., 201911 image) to latest (eg., master branch) after PR #15685 The system wide flag for FAST_REBOOT is still required when the base OS version does not support the new fast-reboot reconciliation logic (no db dump)
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix: #16699
Fast reboot is failing from old OS versions (eg., 201911 image) to latest (eg., master branch) after PR #15685
The system wide flag for FAST_REBOOT is still required when the base OS version does not support the new fast-reboot reconciliation logic (no db dump)
Work item tracking
How I did it
Set system flag for fast reboot during boot up path
How to verify it
Change restores the state as it was before PR 16225, and fast-reboot worked before 16225
Manual tests are in progress.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)