Updated the API get_platform_info() to return running/detected ASIC's count #16539
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -479,15 +479,15 @@ def get_platform_info(config_db=None): | |
| if hw_info_dict: | ||
| return hw_info_dict | ||
|
|
||
| from .multi_asic import get_asic_presence_list | ||
|
|
||
| version_info = get_sonic_version_info() | ||
|
|
||
| hw_info_dict['platform'] = get_platform() | ||
| hw_info_dict['hwsku'] = get_hwsku() | ||
| if version_info: | ||
| hw_info_dict['asic_type'] = version_info.get('asic_type') | ||
| hw_info_dict['asic_count'] = len(get_asic_presence_list()) | ||
|
There was a problem hiding this comment. can we put this change in try/catch to ensure There was a problem hiding this comment. @arlakshm thanks. have updated accordingly. |
||
|
|
||
| try: | ||
| # TODO: enforce caller to provide config_db explicitly and remove its default value | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain the reason for this change? why get_num_asics does not work, but get_asic_presence_list?
what is the scenario that was broken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lguohan
In Chassis for supervisor running asic count can be <= max asic possible.
get_num_asics()return max asic count that can be present based on static file eg:sonic-buildimage/device/nokia/x86_64-nokia_ixr7250e_sup-r0/asic.conf
Line 1 in fe24c26
get_asic_presence_list()returns how many asics are detected on Supervisor and for LC/Multi-asic system it still return max asic count