Skip to content

Update CPU transmitted packets to queue 7 for chassis #16254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Update CPU transmitted packets to queue 7 for chassis #16254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edf49af
Update CPU transmitted packets to TC = 7 for SONIC chassis
vmittal-msft Aug 23, 2023
24d5a20
Added new SOC property to permitted list
vmittal-msft Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...86_64-arista_7800r3_48cq2_lc/Arista-7800R3-48CQ2-C48/jr2-a7280cr3-32d4-40x100G.config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,3 +860,4 @@ dma_desc_aggregator_timeout_usec.BCM8869X=1000
dma_desc_aggregator_enable_specific_MDB_LPM.BCM8869X=1
dma_desc_aggregator_enable_specific_MDB_FEC.BCM8869X=1
sai_pfc_dlr_init_capability=0
sai_default_cpu_tx_tc=7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need this property ? this should be controlled from SAI sonic-net/sonic-swss@04f84fc

Copy link
Collaborator

@gechiang gechiang Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmittal-msft , can you clarify what is the current behavior without this "default" BCM configuration specification?
Would it be up to the BRCM HWSKUs' decision on setting its own default if this is not specified?
@abdosi , Do we currently set this as part of the port attribute during port bring up? If we are not doing it currently, then having a "specified" default setting would be better than don't have it right? Otherwise, we have no way of knowing which BRCM based HWSKU default setting...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is needed as part of the BRCM fix for CPU to send LACP/BGP/LLDP packets on queue-7. In the absence of this property and sai fix, cpu will send packets to queue-0. for XGS platforms, we don't need this as cpu tx packets goes to queue-7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need to check with BRCM if this capability is supported in sai release and can be used instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmittal-msft - we should request DNX SAI to support this SAI attribute.

1 change: 1 addition & 0 deletions ...6_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/0/j2p-a7800r3a-36d-36x400G.config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,3 +1014,4 @@ appl_param_nof_ports_per_modid=64
xflow_macsec_secure_chan_to_num_secure_assoc_encrypt=2
xflow_macsec_secure_chan_to_num_secure_assoc_decrypt=2
sai_pfc_dlr_init_capability=0
sai_default_cpu_tx_tc=7
1 change: 1 addition & 0 deletions ...6_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/1/j2p-a7800r3a-36d-36x400G.config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,3 +1014,4 @@ appl_param_nof_ports_per_modid=64
xflow_macsec_secure_chan_to_num_secure_assoc_encrypt=2
xflow_macsec_secure_chan_to_num_secure_assoc_decrypt=2
sai_pfc_dlr_init_capability=0
sai_default_cpu_tx_tc=7
1 change: 1 addition & 0 deletions ...6_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C72/0/j2p-a7800r3a-36d-36x400G.config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,3 +1031,4 @@ serdes_tx_taps_36=nrz:-8:89:-29:0:0:0
xflow_macsec_secure_chan_to_num_secure_assoc_encrypt=2
xflow_macsec_secure_chan_to_num_secure_assoc_decrypt=4
sai_pfc_dlr_init_capability=0
sai_default_cpu_tx_tc=7
1 change: 1 addition & 0 deletions ...6_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C72/1/j2p-a7800r3a-36d-36x400G.config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,3 +1031,4 @@ serdes_tx_taps_36=nrz:-7:85:-25:0:0:0
xflow_macsec_secure_chan_to_num_secure_assoc_encrypt=2
xflow_macsec_secure_chan_to_num_secure_assoc_decrypt=4
sai_pfc_dlr_init_capability=0
sai_default_cpu_tx_tc=7
1 change: 1 addition & 0 deletions ...6_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-D36/0/j2p-a7800r3a-36d-36x400G.config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,3 +1051,4 @@ appl_param_nof_ports_per_modid=64
xflow_macsec_secure_chan_to_num_secure_assoc_encrypt=2
xflow_macsec_secure_chan_to_num_secure_assoc_decrypt=4
sai_pfc_dlr_init_capability=0
sai_default_cpu_tx_tc=7
1 change: 1 addition & 0 deletions ...6_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-D36/1/j2p-a7800r3a-36d-36x400G.config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,3 +1051,4 @@ appl_param_nof_ports_per_modid=64
xflow_macsec_secure_chan_to_num_secure_assoc_encrypt=2
xflow_macsec_secure_chan_to_num_secure_assoc_decrypt=4
sai_pfc_dlr_init_capability=0
sai_default_cpu_tx_tc=7
1 change: 1 addition & 0 deletions ...4-nokia_ixr7250e_36x400g-r0/Nokia-IXR7250E-36x100G/0/jr2cp-nokia-18x100g-4x25g-config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2093,3 +2093,4 @@ xflow_macsec_secure_chan_to_num_secure_assoc_decrypt=4
cmic_dma_abort_in_cold_boot=0
sai_pfc_dlr_init_capability=0
trunk_group_max_members=16
sai_default_cpu_tx_tc=7
1 change: 1 addition & 0 deletions ...4-nokia_ixr7250e_36x400g-r0/Nokia-IXR7250E-36x100G/1/jr2cp-nokia-18x100g-4x25g-config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2094,3 +2094,4 @@ xflow_macsec_secure_chan_to_num_secure_assoc_decrypt=4
cmic_dma_abort_in_cold_boot=0
sai_pfc_dlr_init_capability=0
trunk_group_max_members=16
sai_default_cpu_tx_tc=7
1 change: 1 addition & 0 deletions .../x86_64-nokia_ixr7250e_36x400g-r0/Nokia-IXR7250E-36x400G/0/jr2cp-nokia-18x400g-config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2095,3 +2095,4 @@ xflow_macsec_secure_chan_to_num_secure_assoc_decrypt=4
cmic_dma_abort_in_cold_boot=0
sai_pfc_dlr_init_capability=0
trunk_group_max_members=16
sai_default_cpu_tx_tc=7
1 change: 1 addition & 0 deletions .../x86_64-nokia_ixr7250e_36x400g-r0/Nokia-IXR7250E-36x400G/1/jr2cp-nokia-18x400g-config.bcm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2097,3 +2097,4 @@ xflow_macsec_secure_chan_to_num_secure_assoc_decrypt=4
cmic_dma_abort_in_cold_boot=0
sai_pfc_dlr_init_capability=0
trunk_group_max_members=16
sai_default_cpu_tx_tc=7
1 change: 1 addition & 0 deletions src/sonic-device-data/tests/permitted_list
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,3 +339,4 @@ svi_my_station_optimization
sai_nbr_bcast_ifp_optimized
sai_pfc_defaults_disable
sai_optimized_mmu
sai_default_cpu_tx_tc