Skip to content

[YANG] add MUX_LINKMGR|SERVICE_MGMT #15927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2023
Merged

[YANG] add MUX_LINKMGR|SERVICE_MGMT #15927

merged 1 commit into from
Aug 2, 2023

Conversation

zjswhhh
Copy link
Contributor

@zjswhhh zjswhhh commented Jul 20, 2023 •
edited
Loading

Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT.

sign-off: Jing Zhang [email protected]

Why I did it

Work item tracking
  • Microsoft ADO (number only): 18445751

How I did it

How to verify it

==================================================================================== test session starts ====================================================================================
platform linux -- Python 3.9.2, pytest-6.0.2, py-1.10.0, pluggy-0.13.0
rootdir: /sonic/src/sonic-yang-models
plugins: pyfakefs-5.2.3, cov-2.10.1
collected 3 items                                                                                                                                                                           

tests/test_sonic_yang_models.py ..                                                                                                                                                    [ 66%]
tests/yang_model_tests/test_yang_model.py .                                                                                                                                           [100%]

===================================================================================== 3 passed in 2.06s =====================================================================================

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@zjswhhh zjswhhh requested a review from qiluo-msft as a code owner July 20, 2023 23:27
@zjswhhh zjswhhh requested review from yxieca and ganglyu July 20, 2023 23:28
ganglyu
ganglyu reviewed Aug 1, 2023
View reviewed changes
src/sonic-yang-models/yang-models/sonic-mux-linkmgr.yang
container SERVICE_MGMT {

leaf kill_radv {
type enumeration {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use boolean instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonic-buildimage/files/scripts/service_mgmt.sh

Lines 43 to 46 in ea34cb2

CONFIG_KNOB=`$SONIC_DB_CLI CONFIG_DB hget "MUX_LINKMGR|SERVICE_MGMT" kill_radv`
if [[ x"$CONFIG_KNOB" == x"False" ]]; then
ACTIVE_ACTIVE='false'
fi

Hi Gang - we have capitalized letters so I can't make the field as boolean.

@yxieca yxieca merged commit b23ec06 into sonic-net:master Aug 2, 2023
@mssonicbld
Copy link
Collaborator

@zjswhhh PR conflicts with 202211 branch

@mssonicbld
Copy link
Collaborator

@zjswhhh PR conflicts with 202205 branch

@mssonicbld
Copy link
Collaborator

@zjswhhh PR conflicts with 202305 branch

@yxieca
Copy link
Contributor

yxieca commented Aug 7, 2023

Need to cherry-pick #15884 first.

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 7, 2023
@zjswhhh @mssonicbld
add service_mgmt (sonic-net#15927)
a27cd7a 
Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT.

sign-off: Jing Zhang [email protected]
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #16070

@mssonicbld mssonicbld mentioned this pull request Aug 7, 2023
Merged
11 tasks
@mssonicbld
Copy link
Collaborator

@zjswhhh PR conflicts with 202211 branch

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 7, 2023
@zjswhhh @mssonicbld
add service_mgmt (sonic-net#15927)
cda517b 
Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT.

sign-off: Jing Zhang [email protected]
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #16071

@mssonicbld mssonicbld mentioned this pull request Aug 7, 2023
Merged
11 tasks
@zjswhhh zjswhhh deleted the service_mgmt_master branch August 7, 2023 17:41
yxieca pushed a commit that referenced this pull request Aug 10, 2023
@mssonicbld @zjswhhh
add service_mgmt (#15927) (#16070)
c2a7dd1 
Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT.

sign-off: Jing Zhang [email protected]

Co-authored-by: Jing Zhang <[email protected]>
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 14, 2023
@zjswhhh @mssonicbld
add service_mgmt (sonic-net#15927)
988af62 
Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT.

sign-off: Jing Zhang [email protected]
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #16138

@mssonicbld mssonicbld mentioned this pull request Aug 14, 2023
Merged
11 tasks
mssonicbld pushed a commit that referenced this pull request Aug 16, 2023
@zjswhhh @mssonicbld
add service_mgmt (#15927)
0352c83 
Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT.

sign-off: Jing Zhang [email protected]
mssonicbld pushed a commit that referenced this pull request Aug 16, 2023
@zjswhhh @mssonicbld
add service_mgmt (#15927)
25662c6 
Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT.

sign-off: Jing Zhang [email protected]
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
@zjswhhh @sonic-otn
add service_mgmt (sonic-net#15927)
25121e2 
Adding yang model for CONFIG_DB table MUX_LINKMGR|SERVICE_MGMT.

sign-off: Jing Zhang [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganglyu ganglyu ganglyu left review comments

@yxieca yxieca yxieca approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

Assignees
No one assigned
Labels
Approved for 202305 Branch Included in 202205 Branch Included in 202211 Branch Included in 202305 Branch Request for 202205 Branch Request for 202211 Branch Request for 202305 Branch YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zjswhhh @mssonicbld @yxieca @ganglyu @StormLiangMS