[yang]SONiC Yang model support for Telemetry_client. (#12483) #13314
Conversation
|
|
Fix compilation error caused by adding sonic-telemetry_client.yang file, missing closing bracket.
| container TELEMETRY_CLIENT { | ||
| container Global { | ||
| leaf retry_interval { | ||
| type uint64; |
There was a problem hiding this comment.
Is there a range for retry interval?
There was a problem hiding this comment.
I checked the code and there is no limitation.
| } | ||
|
|
||
| leaf report_interval { | ||
| type uint64; |
There was a problem hiding this comment.
Is there a range for report interval?
There was a problem hiding this comment.
I checked the code and there is no limitation. But there is a default value of 5000 milliseconds.
There was a problem hiding this comment.
Thanks for sharing! Could you add default value into this yang model?
zhangyanzhao
changed the title
|
|
||
| yang-version 1.1; | ||
|
|
||
| namespace "http://github.com/Azure/sonic-telemetry_client"; |
There was a problem hiding this comment.
Please use sonic-net instead of Azure
| } | ||
|
|
||
| list TELEMETRY_CLIENT_DS_LIST { | ||
| ordered-by user; |
NanQiSweeper
force-pushed
the
telemetry_client_sonic_yang
branch
from
cb6f199 to
a79e48a
Compare
|
@NanQiSweeper can you please help to fix the conflicts and restart the build? Thanks. |
|
@zhangyanzhao OK，i'll fix it. |
NanQiSweeper
force-pushed
the
telemetry_client_sonic_yang
branch
from
40b3ed4 to
a79e48a
Compare
|
@zhangyanzhao Hi, I have resolved the conflict. |
|
@zhangyanzhao Hi, If there is no other problem, can you merge as soon as possible to avoid other conflicts. |
sonic-net#13314) #### Why I did it Create SONIC Yang model for Telemetry_client #### How I did it Defined Yang models based on Guideline doc: https://github.com/Azure/SONiC/blob/master/doc/mgmt/SONiC_YANG_Model_Guidelines.md and https://github.com/Azure/sonic-utilities/blob/master/doc/Command-Reference.md #### How to verify it Added test cases to verify it.
Why I did it
Create SONIC Yang model for Telemetry_client
How I did it
Defined Yang models based on Guideline doc:
https://github.com/Azure/SONiC/blob/master/doc/mgmt/SONiC_YANG_Model_Guidelines.md
and
https://github.com/Azure/sonic-utilities/blob/master/doc/Command-Reference.md
How to verify it
Added test cases to verify it.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)