[sonic-frr] Improve the command to generate dependent files for frr s… #13298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubmodule in frr.dep Issue Description In frr.dep, it lists the dependent files for the submodules through 'git ls-files' and filter the symbolic links through 'grep' with explicitly patterns. The patterns might need to be adjusted upon each frr version upgrade. Enhancement The dependent files can be found by using 'find' to list all of the 'file' under the 'frr' submodule directory and pass the file to 'git ls-files' to know whether the file is included in the git control. Signed-off-by: Charlie Chen <[email protected]>
CharlieChenEC
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
|
|
lguohan
reviewed
Jan 8, 2023
| # Use find to search the type 'symbolic to file' with git ls-files under FRR_SPATH | ||
| # to enumerate those managed by git | ||
| SMDEP_FILES += $(addprefix $(FRR_SPATH)/,$(shell cd $(FRR_SPATH) && \ | ||
| find . -xtype f -exec test -h '''{}''' ';' -exec git ls-files '''{}''' ';' \ |
There was a problem hiding this comment.
what files we filtered out? all symbol links?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ubmodule in frr.dep
Why I did it
In frr.dep, it lists the dependent files for the submodules through
'git ls-files' and filter the symbolic links through 'grep' with
explicitly patterns. The patterns might need to be adjusted upon
each frr version upgrade.
How I did it
The dependent files can be found by using 'find' to list all of the
'file' under the 'frr' submodule directory and pass the file to
'git ls-files' to know whether the file is included in the git
control.
How to verify it
Compare the file 'frr_8.2.2-sonic-0_amd64.deb.smdep' before and after the change and make sure the file contains the correct list, which should include all of the files and symbolic links to file under the 'frr' submodule directory.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Improve the command to generate dependent files for frr submodule in frr.dep
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)