Skip to content

Fixing #12634 #12636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Fixing #12634 #12636

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0875613
Fixing #12634
FuzailBrcm Nov 8, 2022
3388ca3
Fixing #12634: Correcting typo
FuzailBrcm Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions platform/pddf/platform-api-pddf-base/sonic_platform_pddf_base/pddf_sfp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ def get_lpmode(self):
lpmode = super().get_lpmode()
elif xcvr_id == 0x11 or xcvr_id == 0x0d or xcvr_id == 0x0c:
# QSFP28, QSFP+, QSFP
power_set = self.get_power_set()
# get_power_set() is not defined in the optoe_base class
api = self.get_xcvr_api()
power_set = api.get_power_set()
power_override = self.get_power_override()
# By default the lpmode pin is pulled high as mentioned in the sff community
return power_set if power_override else True
Expand Down Expand Up @@ -342,9 +344,9 @@ def set_lpmode(self, lpmode):
elif xcvr_id == 0x11 or xcvr_id == 0x0d or xcvr_id == 0x0c:
# QSFP28, QSFP+, QSFP
if lpmode is True:
self.set_power_override(True, True)
status = self.set_power_override(True, True)
else:
self.set_power_override(True, False)
status = self.set_power_override(True, False)

return status

Expand Down