Skip to content

Add a yang model for the new "Logger" table in the CONFIG DB #12067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 31, 2022

Conversation

EdenGri
Copy link
Contributor

@EdenGri EdenGri commented Sep 14, 2022

Signed-off-by: EdenGri [email protected]

This PR should be merged together with the following PRs as there is dependency between them:

Why I did it

Add the ability to the user to save the loglevel and make it persistent to reboot.

How I did it

Move the logger tables from the LOGLEVEL DB to the CONFIG DB. Add new yang model to verify the new config schema.

How to verify it

  1. change the orchagent loglevel (for example) -> swssloglevel -c orchagent -l DEBUG
  2. save the loglevel -> run config save
  3. reboot
  4. verify that the orchagent log level is still DEBUG ->run run redis-cli -n 4 hgetall "LOGGER|orchagent"

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@dprital dprital marked this pull request as draft September 14, 2022 11:06
@dprital dprital marked this pull request as ready for review September 19, 2022 11:17
@dgsudharsan dgsudharsan added the YANG YANG model related changes label Sep 29, 2022
@EdenGri
Copy link
Contributor Author

EdenGri commented Oct 6, 2022

The tests that failed are:
bgp/test_traffic_shift.py::test_TSA[vlab-03]
tacacs/test_rw_user.py::test_rw_user[vlab-08]

@EdenGri
Copy link
Contributor Author

EdenGri commented Oct 6, 2022

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@EdenGri
Copy link
Contributor Author

EdenGri commented Oct 6, 2022

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft requested a review from ganglyu October 6, 2022 17:48
@qiluo-msft
Copy link
Collaborator

Could you refine your PR title?

Copy link
Member

@praveen-li praveen-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thx

@EdenGri EdenGri changed the title Persistent loglevel Add a yang model for the new "Logger" table in the CONFIG DB Oct 8, 2022
@EdenGri EdenGri force-pushed the persistent_loglevel branch from b0d9337 to 4dad806 Compare October 10, 2022 17:02
@EdenGri
Copy link
Contributor Author

EdenGri commented Oct 11, 2022

The test that failed is:
container_checker/test_container_checker.py::test_container_checker[vlab-03-None-lldp]

@EdenGri
Copy link
Contributor Author

EdenGri commented Oct 11, 2022

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EdenGri
Copy link
Contributor Author

EdenGri commented Oct 11, 2022

failed in the test: configlet/test_add_rack.py::test_add_rack
in the previous running, this test was passed

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ganglyu
Copy link
Contributor

ganglyu commented Oct 18, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EdenGri
Copy link
Contributor Author

EdenGri commented Oct 18, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 12067 in repo sonic-net/sonic-buildimage

@ganglyu
Copy link
Contributor

ganglyu commented Oct 18, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EdenGri EdenGri force-pushed the persistent_loglevel branch from 4dad806 to 74ae9fa Compare October 26, 2022 10:20
@EdenGri
Copy link
Contributor Author

EdenGri commented Oct 26, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 12067 in repo sonic-net/sonic-buildimage

@zhangyanzhao
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EdenGri EdenGri marked this pull request as ready for review October 31, 2022 08:24
@liat-grozovik liat-grozovik merged commit 6bed69a into sonic-net:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
YANG YANG model related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants