Skip to content

[swss]: Update sonic-swss submodule #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2017
Merged

[swss]: Update sonic-swss submodule #1165

merged 1 commit into from
Nov 18, 2017

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Nov 17, 2017

It contains:
[pfcactionhandler]: match correct value when aclhandler creates ACL rules (#393)
[orchagent]: Fix issue with bind ACL table group to port (#386)
[vlanmgrd]: Use sonic-swss-common instead of exec redis-cli (#392)

Signed-off-by: Shu0T1an ChenG [email protected]

It contains:
 [pfcactionhandler]: match correct value when aclhandler creates ACL rules (sonic-net#393)
 [orchagent]: Fix issue with bind ACL table group to port (sonic-net#386)
 [vlanmgrd]: Use sonic-swss-common instead of exec redis-cli (sonic-net#392)

Signed-off-by: Shu0T1an ChenG <[email protected]>
Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check build

@stcheng
Copy link
Contributor Author

stcheng commented Nov 18, 2017

error pulling image configuration it seems some network issue of getting things from the internet.

@stcheng stcheng merged commit eef4a89 into sonic-net:master Nov 18, 2017
@stcheng stcheng deleted the swss branch November 18, 2017 01:20
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request May 31, 2025
…n sensors.conf for 7060X6-64PE-B (sonic-net#1165)

<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "fixes #xxxx", or
 "closes #xxxx" or "resolves #xxxx"

 Please provide the following information:
-->

#### Why I did it
The `sensors.conf` file was referencing a non-existent NVMe PCI address (`nvme-pci-0500`) on the Arista-7060X6-64PE-B platform. This mismatch caused `pmon#sensord` to report repeated I/O errors while attempting to read sensor data for a non-existent device (`nvme/#7`). Updating the config to use the correct PCI address (`nvme-pci-0400`) resolves the issue.

##### Work item tracking
- Microsoft ADO **(number only)**: 32849896

#### How I did it
Modified `sensors.conf` to change the chip identifier from `nvme-pci-0500` to `nvme-pci-0400` to match the actual hardware PCI bus location.

#### How to verify it

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->
- Verified that the `/dev/nvme*` devices are present and functional
- Confirmed correct PCI ID using `lspci`
```
$ show plat sum
Platform: x86_64-arista_7060x6_64pe_b
HwSKU: Arista-7060X6-64PE-B-C512S2
ASIC: broadcom
ASIC Count: 1
Serial Number: XXXXXXXX
Model Number: DCS-7060X6-64PE-B
Hardware Revision: 02.00
$ lspci -nn | grep -i nvme
04:00.0 Non-Volatile memory controller [0108]: Phison Electronics Corporation E18 PCIe4 NVMe Controller [1987:5018] (rev 01)
```
- Edited `sensors.conf` and restarted `pmon` (`systemctl restart pmon`)
- Monitored logs to ensure `pmon#sensord` no longer reports I/O errors for `nvme/#7`

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305
- [x] 202412

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [SONiC.20241211.16 ] <!-- image version 1 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
Fix `sensors.conf` NVMe chip config for Arista-7060X6-64PE-B to match actual PCI address and prevent pmon sensor read errors

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants