-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[swss]: Update sonic-swss submodule #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It contains: [pfcactionhandler]: match correct value when aclhandler creates ACL rules (sonic-net#393) [orchagent]: Fix issue with bind ACL table group to port (sonic-net#386) [vlanmgrd]: Use sonic-swss-common instead of exec redis-cli (sonic-net#392) Signed-off-by: Shu0T1an ChenG <[email protected]>
lguohan
approved these changes
Nov 17, 2017
qiluo-msft
approved these changes
Nov 18, 2017
qiluo-msft
approved these changes
Nov 18, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check build
|
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
May 31, 2025
…n sensors.conf for 7060X6-64PE-B (sonic-net#1165) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it The `sensors.conf` file was referencing a non-existent NVMe PCI address (`nvme-pci-0500`) on the Arista-7060X6-64PE-B platform. This mismatch caused `pmon#sensord` to report repeated I/O errors while attempting to read sensor data for a non-existent device (`nvme/#7`). Updating the config to use the correct PCI address (`nvme-pci-0400`) resolves the issue. ##### Work item tracking - Microsoft ADO **(number only)**: 32849896 #### How I did it Modified `sensors.conf` to change the chip identifier from `nvme-pci-0500` to `nvme-pci-0400` to match the actual hardware PCI bus location. #### How to verify it <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> - Verified that the `/dev/nvme*` devices are present and functional - Confirmed correct PCI ID using `lspci` ``` $ show plat sum Platform: x86_64-arista_7060x6_64pe_b HwSKU: Arista-7060X6-64PE-B-C512S2 ASIC: broadcom ASIC Count: 1 Serial Number: XXXXXXXX Model Number: DCS-7060X6-64PE-B Hardware Revision: 02.00 $ lspci -nn | grep -i nvme 04:00.0 Non-Volatile memory controller [0108]: Phison Electronics Corporation E18 PCIe4 NVMe Controller [1987:5018] (rev 01) ``` - Edited `sensors.conf` and restarted `pmon` (`systemctl restart pmon`) - Monitored logs to ensure `pmon#sensord` no longer reports I/O errors for `nvme/#7` #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 - [x] 202412 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [SONiC.20241211.16 ] <!-- image version 1 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> Fix `sensors.conf` NVMe chip config for Arista-7060X6-64PE-B to match actual PCI address and prevent pmon sensor read errors <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It contains:
[pfcactionhandler]: match correct value when aclhandler creates ACL rules (#393)
[orchagent]: Fix issue with bind ACL table group to port (#386)
[vlanmgrd]: Use sonic-swss-common instead of exec redis-cli (#392)
Signed-off-by: Shu0T1an ChenG [email protected]