Skip to content

DellEMC: S52xx Reboot cause fix #10783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2022

Conversation

aravindmani-1
Copy link
Contributor

Why I did it

Reboot cause is not updated properly in DellEMC S5232f.

How I did it

Modified chassis.py to fix the issue

How to verify it

Execute different reboot methods and confirm the behavior.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

UT:
reboot_cause UT.txt

@aravindmani-1
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aravindmani-1
Copy link
Contributor Author

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 10783 in repo Azure/sonic-buildimage

@aravindmani-1
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aravindmani-1
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aravindmani-1
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aravindmani-1 aravindmani-1 force-pushed the reboot_cause_fix branch 3 times, most recently from df9dfbf to 170a5b2 Compare May 18, 2022 04:12
@aravindmani-1
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prgeor prgeor requested a review from lizhuhuams May 18, 2022 16:10
@aravindmani-1 aravindmani-1 requested a review from lizhuhuams May 19, 2022 04:01
@aravindmani-1 aravindmani-1 force-pushed the reboot_cause_fix branch 2 times, most recently from 6108157 to 37acfc8 Compare May 19, 2022 10:26
@aravindmani-1
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prgeor
Copy link
Contributor

prgeor commented May 19, 2022

@aravindmani-1 please rebase

Copy link
Contributor

@lizhuhuams lizhuhuams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@prgeor prgeor merged commit 9caf128 into sonic-net:202012 May 24, 2022
@aravindmani-1 aravindmani-1 deleted the reboot_cause_fix branch May 24, 2022 04:04
@lizhuhuams
Copy link
Contributor

lizhuhuams commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants