-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Nokia ixs7215] Platform API temperature threshold value fixes #10533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Blueve
merged 6 commits into
sonic-net:202012
from
dflynn-Nokia:202012-temp-threshold-fixes
Apr 25, 2022
Merged
[Nokia ixs7215] Platform API temperature threshold value fixes #10533
Blueve
merged 6 commits into
sonic-net:202012
from
dflynn-Nokia:202012-temp-threshold-fixes
Apr 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrect high-threshold and critical-high-threshold values are displayed for some of the temperature sensors. This commit fixes that.
@qiluo-msft Can we move this one forward? |
qiluo-msft
approved these changes
Apr 15, 2022
@qiluo-msft , can we merge this approved PR please? |
/azp list |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect high-threshold and critical-high-threshold values are displayed for
some of the temperature sensors. This commit fixes that.
This is a backport of PR# 10372
Why I did it
Incorrect high-threshold and critical-high-threshold values are displayed for
some of the temperature sensors
How I did it
Modify the thermal sensor Platform API 2.0 implementation to return the correct values.
How to verify it
Ensure that the 'show platform temperature' command show the correct high-threshold and critical-high-threshold values for each thermal sensor.
Values displayed before the fix.
Values displayed after the fix
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)