[sonic-utilities]: Build as Debian package once again (revert change to wheel) #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you resolve the conflicts? |
|
@stcheng: Done. |
stcheng
approved these changes
Oct 6, 2017
lguohan
pushed a commit
that referenced
this pull request
Aug 14, 2019
[sairedis]: ARM32 bit fixes, for 64bit printf format specifier (#490) fix wrong API type , add cmdline parse option , remove unuseful api call (#499) Use pointer to member function to reduce the footprint of collectCounters() (#488) [syncd] Add support for Innovium platform (#496) [saisdkdump]: Fix dump generation crash (#493) [swss]: Add scope attribute to VNET table. (#954) [portsyncd]: Fix portsyncd restart case (#1019) [vnet]: Enable "vnet_orch_1" VS test case (#1020) [vlan] Add pytest cases to validate the behavior about add LAG member to vlan. (#875) [policerorch]: Add the capability to update policer rate/size (#1017) [aclorch]: Add MIRRORv6 support for NPS platform (#1018) [orchagent]: Avoid crash by setting g_syncMode flag before create_switch (#1014) [orchagent] Add support for Innovium platform (#1005) Provide broadcast IP while configuring interface ip address (#1007) [VLAN] Add pytest cases to validate different use-case of tagging_mode. (#860) [vstest]: Add test_port_config.py which include breakout port test. (#866) [vstests]: change 'test_acl_egress_table.py' to UNIX format (#1010) [vlan] Add pytest cases to verify data in app db and state db. (#895) [vstest]: Add the CRM tests (#1013) [warm-reboot]: add bgp eoiu support to speed up route reconcile (#856) [fdborch] support mac update (#877) [vxlanorch] Fix Logic of Vxlan tunnel removal (#995) Fix VLAN error introduced with new 4.9 kernel behavior (#1001) Config DB manual is being moved from Wiki to SWSS repo (#1002) Trap DHCPv6 packets for supporting ZTP over in-band interfaces using … (#997) Signed-off-by: Andriy Kokhan <[email protected]>
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Oct 17, 2019
…to wheel) (sonic-net#1018) RB=1127438 G=lnos-reviewers R=ntrianta,rjonnadu,rmolina,sfardeen,zxu A=
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
Signed-off-by: Jared.Liu <[email protected]>
stephenxs
pushed a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Aug 14, 2020
[db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches (sonic-net#993) [show/vlan]: fix show vlan config (sonic-net#1050) [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (sonic-net#1018) [config] Eliminate port breakout-related globals (sonic-net#1045) [teamshow]: refactor teamshow to use state db information (sonic-net#1049) [watermarkstat] Import print_function from __future__ (sonic-net#1048) [show]: split show interfaces commands into separate file (sonic-net#1044) Python 3 compliance (sonic-net#1043) Update all references to new 'sonic-installer' file name (sonic-net#1033) [config/show]: split vlan into separate file (sonic-net#1038) [pytest/coverage]: add coverage for all scripts (sonic-net#1041) enable watchdog before running platform specific reboot plugin (sonic-net#1037) [tests]:add coverage for config/main/utilities_common module (sonic-net#1039) [cli/feature]: split feature command into a separate file (sonic-net#1034) Signed-off-by: Stephen Sun <[email protected]>
lguohan
pushed a commit
that referenced
this pull request
Aug 14, 2020
[db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches (#993) [show/vlan]: fix show vlan config (#1050) [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (#1018) [config] Eliminate port breakout-related globals (#1045) [teamshow]: refactor teamshow to use state db information (#1049) [watermarkstat] Import print_function from __future__ (#1048) [show]: split show interfaces commands into separate file (#1044) Python 3 compliance (#1043) Update all references to new 'sonic-installer' file name (#1033) [config/show]: split vlan into separate file (#1038) [pytest/coverage]: add coverage for all scripts (#1041) enable watchdog before running platform specific reboot plugin (#1037) [tests]:add coverage for config/main/utilities_common module (#1039) [cli/feature]: split feature command into a separate file (#1034) Signed-off-by: Stephen Sun <[email protected]> Co-authored-by: Stephen Sun <[email protected]>
abdosi
added a commit
that referenced
this pull request
Sep 3, 2020
Fix error when running 'show lldp table' or 'show lldp neighbor' through SSH command. (#1067) [201911]: Multi asic show interface support (#1070) [counterpoll] Add new FC group for port buffer drop counters (#1024) [201911] show interface portchannel support for Multi ASIC (#1071) Fix a typo in mellanox_buffer_migrator (#1090) Fix pfcwd stats crash with invalid queue name (#1077) [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (#1018) enable watchdog before running platform specific reboot plugin (#1037) Add namespace of the process in the coredump filename. (#1091)
wangshengjun
pushed a commit
to wangshengjun/sonic-buildimage
that referenced
this pull request
Nov 16, 2020
[sairedis]: ARM32 bit fixes, for 64bit printf format specifier (sonic-net#490) fix wrong API type , add cmdline parse option , remove unuseful api call (sonic-net#499) Use pointer to member function to reduce the footprint of collectCounters() (sonic-net#488) [syncd] Add support for Innovium platform (sonic-net#496) [saisdkdump]: Fix dump generation crash (sonic-net#493) [swss]: Add scope attribute to VNET table. (sonic-net#954) [portsyncd]: Fix portsyncd restart case (sonic-net#1019) [vnet]: Enable "vnet_orch_1" VS test case (sonic-net#1020) [vlan] Add pytest cases to validate the behavior about add LAG member to vlan. (sonic-net#875) [policerorch]: Add the capability to update policer rate/size (sonic-net#1017) [aclorch]: Add MIRRORv6 support for NPS platform (sonic-net#1018) [orchagent]: Avoid crash by setting g_syncMode flag before create_switch (sonic-net#1014) [orchagent] Add support for Innovium platform (sonic-net#1005) Provide broadcast IP while configuring interface ip address (sonic-net#1007) [VLAN] Add pytest cases to validate different use-case of tagging_mode. (sonic-net#860) [vstest]: Add test_port_config.py which include breakout port test. (sonic-net#866) [vstests]: change 'test_acl_egress_table.py' to UNIX format (sonic-net#1010) [vlan] Add pytest cases to verify data in app db and state db. (sonic-net#895) [vstest]: Add the CRM tests (sonic-net#1013) [warm-reboot]: add bgp eoiu support to speed up route reconcile (sonic-net#856) [fdborch] support mac update (sonic-net#877) [vxlanorch] Fix Logic of Vxlan tunnel removal (sonic-net#995) Fix VLAN error introduced with new 4.9 kernel behavior (sonic-net#1001) Config DB manual is being moved from Wiki to SWSS repo (sonic-net#1002) Trap DHCPv6 packets for supporting ZTP over in-band interfaces using … (sonic-net#997) Signed-off-by: Andriy Kokhan <[email protected]>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
[db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches (sonic-net#993) [show/vlan]: fix show vlan config (sonic-net#1050) [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (sonic-net#1018) [config] Eliminate port breakout-related globals (sonic-net#1045) [teamshow]: refactor teamshow to use state db information (sonic-net#1049) [watermarkstat] Import print_function from __future__ (sonic-net#1048) [show]: split show interfaces commands into separate file (sonic-net#1044) Python 3 compliance (sonic-net#1043) Update all references to new 'sonic-installer' file name (sonic-net#1033) [config/show]: split vlan into separate file (sonic-net#1038) [pytest/coverage]: add coverage for all scripts (sonic-net#1041) enable watchdog before running platform specific reboot plugin (sonic-net#1037) [tests]:add coverage for config/main/utilities_common module (sonic-net#1039) [cli/feature]: split feature command into a separate file (sonic-net#1034) Signed-off-by: Stephen Sun <[email protected]> Co-authored-by: Stephen Sun <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
…onic-net#1018) - What I did Fixed issue with pfcwd show stats command during SONiC init. Traceback was returned if DB was not yet initialized which is incorrect. Correct behavior would to rather return empty line if something is not yet ready to be pulled and displayed. - How I did it Returned empty dictionary instead of None if data are still not present in DB. It is because in source code data expected to be as dictionary type but if there is no expected attributes in DB None was returned. Wich is incorrect and caused following exception: 'NoneType' object has no attribute 'keys' Signed-off-by: Volodymyr Samotiy <[email protected]>
DavidZagury
pushed a commit
to DavidZagury/sonic-buildimage
that referenced
this pull request
Apr 28, 2025
… design (sonic-net#1018) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Preivously, every bgpcfgd manager need to wait on all of its dependencies to be ready before it can start processing next SET command. It was very inflexible and hurts performance particularly for SRv6 manager. To reproduce the issue, a user can try the following config sequence: ``` sonic-db-cli CONFIG_DB HSET 'SRV6_MY_SIDS|loc1|fcbb:bbbb:1::/48' action 'uN' sonic-db-cli CONFIG_DB HSET 'SRV6_MY_SIDS|loc2|fcbb:bbbb:2::/48' action 'uN' sonic-db-cli CONFIG_DB HSET 'SRV6_MY_SIDS|loc3|fcbb:bbbb:3::/48' action 'uN' sonic-db-cli CONFIG_DB HSET 'SRV6_MY_SIDS|loc4|fcbb:bbbb:4::/48' action 'uN' sonic-db-cli CONFIG_DB HSET 'SRV6_MY_LOCATORS|loc1' prefix "fcbb:bbbb:1::" sonic-db-cli CONFIG_DB HSET 'SRV6_MY_LOCATORS|loc2' prefix "fcbb:bbbb:2::" sonic-db-cli CONFIG_DB HSET 'SRV6_MY_LOCATORS|loc3' prefix "fcbb:bbbb:3::" sonic-db-cli CONFIG_DB HSET 'SRV6_MY_LOCATORS|loc4' prefix "fcbb:bbbb:4::" ``` Without this optimization, all 4 SIDs won't be programmed until the last locator is set. With the optimization, the first SID will be programmed at the time the first locator is set and the second SID will be programmed at the time the second locator is set, vice versa. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it I added a knob to allow developers to control whether a manager needs to wait on all dependencies. #### How to verify it Run UT and test it out on virtual or physical platforms. <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swsssdk package is installed as a wheel. If we compile sonic-utilities as a wheel, it will locate the swsssdk package dependency. However, if we compile sonic-utilities as a Debian package, it will look for a swsssdk Debian package, fail to find it, and the installation will fail.
However, building as a wheel introduced a few unexpected changes, such as installing the scripts in /usr/local/bin vs. /usr/bin, as well as the lack of ability to copy files outside of python package directory (i.e., bash_completion files to /etc/bash_completion.d/).
For now, we remove this explicit dependency in order to revert back to building sonic-utilities as a Debian package until we find a better solution, as we should specify all dependencies to ensure proper builds in case something goes wrong with the swsssdk installation. Ultimately, it would be great if we could build Debian packages that depend on wheels and vice-versa.