Skip to content

[Arista] Add emmc quirks in boot0 to improve reliability #10013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

Staphylo
Copy link
Collaborator

@Staphylo Staphylo commented Feb 17, 2022

Why I did it

Fix some unreliability seen on emmc device with some AMD CPUs

How I did it

Added a kernel parameter to add quirks to
It depends on a sonic-linux-kernel change to work properly but will be a no-op without it.
The quirk added is SDHCI_QUIRK2_BROKEN_HS200 used to downgrade the link speed for the eMMC.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Add emmc quirks for Upperlake

@Staphylo Staphylo requested a review from lguohan as a code owner February 17, 2022 16:41
@prgeor prgeor self-assigned this Feb 18, 2022
@prgeor
Copy link
Contributor

prgeor commented Feb 18, 2022

@Staphylo could you describe in the description:

  1. What was the issue seen?
  2. How is this quirk fixing this?

@Staphylo Staphylo force-pushed the master-boot0-emmc-fixes branch from ec7636b to fe927d2 Compare January 31, 2023 16:32
@prgeor prgeor removed their assignment Jan 31, 2023
@prgeor
Copy link
Contributor

prgeor commented Jan 31, 2023

@lguohan please help merge

@lguohan lguohan merged commit dd7948b into sonic-net:master Feb 9, 2023
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Feb 9, 2023
…0013)

Why I did it
Fix some unreliability seen on emmc device with some AMD CPUs

How I did it
Added a kernel parameter to add quirks to
It depends on a sonic-linux-kernel change to work properly but will be a no-op without it.
The quirk added is SDHCI_QUIRK2_BROKEN_HS200 used to downgrade the link speed for the eMMC.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #13743

yxieca pushed a commit that referenced this pull request Feb 10, 2023
…3743)

Why I did it
Fix some unreliability seen on emmc device with some AMD CPUs

How I did it
Added a kernel parameter to add quirks to
It depends on a sonic-linux-kernel change to work properly but will be a no-op without it.
The quirk added is SDHCI_QUIRK2_BROKEN_HS200 used to downgrade the link speed for the eMMC.

Co-authored-by: Samuel Angebault <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #13853

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Feb 17, 2023
…0013)

Why I did it
Fix some unreliability seen on emmc device with some AMD CPUs

How I did it
Added a kernel parameter to add quirks to
It depends on a sonic-linux-kernel change to work properly but will be a no-op without it.
The quirk added is SDHCI_QUIRK2_BROKEN_HS200 used to downgrade the link speed for the eMMC.
mssonicbld pushed a commit that referenced this pull request Feb 17, 2023
Why I did it
Fix some unreliability seen on emmc device with some AMD CPUs

How I did it
Added a kernel parameter to add quirks to
It depends on a sonic-linux-kernel change to work properly but will be a no-op without it.
The quirk added is SDHCI_QUIRK2_BROKEN_HS200 used to downgrade the link speed for the eMMC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants