-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[201811] [201911] Build failing due to pip setuptools version upgrade #5279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See: sonic-net#5279 Signed-off-by: Zhenggen Xu <[email protected]>
See: sonic-net#5279 Signed-off-by: Zhenggen Xu <[email protected]>
Pin down setuptools version to fix build issues. See: #5279 Signed-off-by: Zhenggen Xu <[email protected]>
Seems the issue is fixed by upstream pypa/setuptools#2352 |
it looks like not in 50.0.1, but probably a later release which is not available yet. We could wait if you guys prefer, but I feel we should make a more deterministic build ourselves, depending on upstream dynamics for our build in general is not a good idea. |
I'm OK with keeping this change in order to make a more deterministic build. We have been locking down more and more package versions for this reason. Package updates will no longer be unexpected; we will have more control over when we upgrade the packages. |
See: #5279 Signed-off-by: Zhenggen Xu <[email protected]>
See: sonic-net#5279 Signed-off-by: Zhenggen Xu <[email protected]> RB=2260960 G=lnos-reviewers R=pchaudha,pmao,vapatil,zxu A=
See: sonic-net#5279 Signed-off-by: Zhenggen Xu <[email protected]> RB=2260960 G=lnos-reviewers R=pchaudha,pmao,vapatil,zxu A=
Description
Build for 201811 and 201911 fails while building target/docker-snmp-sv2.gz
This is due to issue: pypa/setuptools#2352
Steps to reproduce the issue:
Build 201811 or 201911, you will hit below error:
Describe the results you received:
See above.
Describe the results you expected:
Build succesfully.
Additional information you deem important (e.g. issue happens only occasionally):
The text was updated successfully, but these errors were encountered: