[Bug] - 'show queue wredcounter' requires 'WRED_ECN_QUEUE' & 'WRED_ECN_PORT' to the FLEX_COUNTER_TABLE

[amitpawar12]

Is it platform specific

generic

Importance or Severity

Critical

Description of the bug

Support to count and display ECN marked packets is added to -show queue wredcounter' CLI via PR -sonic-net/sonic-utilities#2807

However, for this to work, the minigraph/config_db needs to have additional parameters in FLEX_COUNTER_TABLE.

Note - This support is ONLY available post SAI 12.x.

@saksarav-nokia , @vmittal-msft for viz.

Existing table:

{
  "ACL": {
    "FLEX_COUNTER_STATUS": "enable",
    "POLL_INTERVAL": "10000"
  },
  "BUFFER_POOL_WATERMARK": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "PFCWD": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "PG_DROP": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "PG_WATERMARK": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "PORT": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "PORT_BUFFER_DROP": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "QUEUE": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "QUEUE_WATERMARK": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "RIF": {
    "FLEX_COUNTER_STATUS": "enable"
  }
}

New table:

{
  "ACL": {
    "FLEX_COUNTER_STATUS": "enable",
    "POLL_INTERVAL": "10000"
  },
  "BUFFER_POOL_WATERMARK": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "PFCWD": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "PG_DROP": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "PG_WATERMARK": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "PORT": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "PORT_BUFFER_DROP": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "QUEUE": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "QUEUE_WATERMARK": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "RIF": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  **"WRED_ECN_QUEUE": {
    "FLEX_COUNTER_STATUS": "enable"
  },
  "WRED_ECN_PORT": {
    "FLEX_COUNTER_STATUS": "enable"
  }**
}

Steps to Reproduce

ECN test:

• Check for default Kmin, Kmax parameters configured.
• For BRCM-DNX chassis, disable PFC_WD and CREDIT_WD.
• Send pause on the egress.
• Send packets in range of Kmin and Kmax.
• Start capture on egress port.
• Stop the pause on egress.
• Analyze the captured packets for the ECN marking.

Run the ECN test and check the CLI output - show queue wredcounter -n

Actual Behavior and Expected Behavior

Actual behavior:
The counters are shown as zero.

Expected behavior:
The counters should increment.

Workaround:
The minigraph/config_db should have additional parameter defined above. Once added, config_reload on the DUT and repeat the test.

There should be some mechanism to have the WRED_ECN_QUEUE & WRED_ECN_PORT to the FLEX_COUNTER_TABLE in the config_db/minigraph.

Relevant log output

Output of show version, show techsupport

Attach files (if any)

No response

[vmittal-msft]

@rpmarvell Can you please check why WRED_ECN_QUEUE & WRED_ECN_PORT are not getting added to FLEX_COUNTER_TABLE. I checked the code and it seems we need to register these counters into FLEX_COUNTER_TABLE as being done by other modules. Which seems to be missing in initial commit. Please check and let us know if you need any clarification.

[vmittal-msft]

We may need to call this to register new stats. Please check.

[abdosi]

@alpeshspatel @zhixzhu : can you also check if this supported on Cisco platforms.

@vmittal-msft : can you check do we have any functional converge of this counter in sonic-mgmt ptf based or even in ixia

[zhixzhu]

@abdosi Some SAI attributes are supported on Cisco platforms.

Supported: SAI_QUEUE_STAT_WRED_ECN_MARKED_PACKETS, SAI_QUEUE_STAT_WRED_DROPPED_PACKETS, SAI_QUEUE_STAT_WRED_DROPPED_BYTES, SAI_PORT_STAT_WRED_DROPPED_PACKETS, SAI_PORT_STAT_ECN_MARKED_PACKETS

Not supported (value is 0): SAI_QUEUE_STAT_WRED_ECN_MARKED_BYTES, SAI_PORT_STAT_GREEN_WRED_DROPPED_PACKETS, SAI_PORT_STAT_YELLOW_WRED_DROPPED_PACKETS, SAI_PORT_STAT_RED_WRED_DROPPED_PACKETS