Skip to content

[dump] Add ACL modules #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2022
Merged

Conversation

stepanblyschak
Copy link
Contributor

Signed-off-by: Stepan Blyschak [email protected]

Signed-off-by: Stepan Blyschak <[email protected]>
@yxieca yxieca force-pushed the master branch 2 times, most recently from 8498931 to 8837dc2 Compare April 15, 2022 16:51
@liat-grozovik
Copy link
Collaborator

@vivekreddynv could you please help to review?


### 3.1 ACL Table

ACL Tables configuration resieds in CONFIG DB in table *ACL_TABLE*. Tables in *ACL_TABLE* may reference another table *ACL_TABLE_TYPE* that holds the table type configuration or may use one of default table types (L3, L3V6, MIRROR, etc.). This information is dumped from CONFIG DB. Orchagent processes *ACL_TABLE* and *ACL_TABLE_TYPE* configuration and manages the following ASIC resources:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "resides"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

@liat-grozovik
Copy link
Collaborator

@vivekreddynv could you please approve?
@bingwang-ms as this is related to ACL would you mind to take a look as well?

@liat-grozovik
Copy link
Collaborator

@bingwang-ms kindly reminder to review.

liat-grozovik pushed a commit to sonic-net/sonic-utilities that referenced this pull request May 23, 2022
- What I did
Implemented ACL dump modules

- How I did it
Added dump plugins for acl_rule and acl_table.
Added UT for coverage.
Implemented according to sonic-net/SONiC#983

- How to verify it
Run UT, run on the switch mannually.

Signed-off-by: Stepan Blyschak <[email protected]>
@liat-grozovik liat-grozovik merged commit 4a5edee into sonic-net:master May 25, 2022
malletvapid23 added a commit to malletvapid23/Sonic-Utility that referenced this pull request Aug 3, 2023
- What I did
Implemented ACL dump modules

- How I did it
Added dump plugins for acl_rule and acl_table.
Added UT for coverage.
Implemented according to sonic-net/SONiC#983

- How to verify it
Run UT, run on the switch mannually.

Signed-off-by: Stepan Blyschak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants