-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix linting errors #6240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mamhoff
wants to merge
40
commits into
solidusio:main
Choose a base branch
from
mamhoff:fix-linting-errors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix linting errors #6240
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
4796d16
Remove Rubocop.yml deprecation warnings
mamhoff 3d0df68
Update validation syntax
mamhoff abfa512
Replace `puts` in tasks and generators with Rails.logger
mamhoff b133f7f
Refactor load_user_roles into current_user_roles helper
mamhoff 3c629ad
Refactor "current_api_user" into instacached helper
mamhoff e63b830
UserAddress: Add dependent/inverse_of options
mamhoff e29db18
UserMethods: Add dependent/inverse_of to relations
mamhoff da5c067
AdjustmentReason: Add :dependent option
mamhoff eb8eb2a
Country: Add dependent/inverse_of options
mamhoff b0fd9a1
CustomerReturn: Add dependent option to has_many's
mamhoff f3e9a4f
Inventory Unit: Add inverse_of/dependent options
mamhoff 907309e
Credit Card: Specify inverse_of for :user association
mamhoff e566086
Line Item: Specify dependent option for inventory units
mamhoff 398b401
Order: Add inverse_of/dependent options
mamhoff 8db61db
Payment Method: Add :dependent options
mamhoff 8588b90
Payment: Add dependent: :destroy
mamhoff 5123e21
Payment Source: Add dependent: :restrict_with_error
mamhoff 378e325
PermissionSet: Add dependent: :destroy
mamhoff 5ada7c8
StockLocation: Add dependent: :restrict_with_error
mamhoff 0715fa8
Store Credits: Add dependent: options
mamhoff 639c808
UserAddress: Add :inverse_of option
mamhoff 35d104d
Variant: Add inverse_of and dependent options
mamhoff 59e3cbd
Price: Add inverse_of options
mamhoff 260fe3d
Product: Add dependent: options
mamhoff 238d4aa
Reimbursements and returns: Specify dependent/inverse_ofs
mamhoff b40408d
Shipment: Add dependent: :destroy
mamhoff c2a03e0
Shipping Method: Add dependent: / inverse_of: options
mamhoff 8541702
Stock Item: Add dependent: :destroy
mamhoff ddea5f5
Store: Add dependent: options
mamhoff 889c751
Tax Rate: Add dependent: :restrict_with_error
mamhoff e96af0c
Shipping Category: Add dependent: options
mamhoff c853f3a
Move Taxon -> Promotion Rule association to legacy promotions
mamhoff 0079516
Taxonomy: Add dependent: false options
mamhoff 61d17c6
Legacy Promotions: Add inverse_of/dependent options
mamhoff a51058c
Disable Rails/LexicallyScopedActionFilter
mamhoff d9c3f77
Backend: Disable Rails/HelperInstanceVariable cop
mamhoff 41c66d1
Ignore Rails/Exit warning in rescue clause
mamhoff 998621e
Promotions: Specify inverse_of/dependent options
mamhoff 6ca7f71
Fix taxon patch
mamhoff e1dc7b6
Aktualisieren von spree_taxon_patch.rb
mamhoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about using
restrict_with_error
instead? So that we can display the error message on the record we try do delete instead of rendering a 500 in the admin. Otherwise we would need torescue_from ActiveRecord::DeleteRestrictionError
in the backend.