Update importmap-rails to v2 #6202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_admin
changelog:solidus_promotions
tvdeyen
changed the title
mamhoff
approved these changes
Mar 31, 2025
jarednorman
previously approved these changes
Mar 31, 2025
tvdeyen
force-pushed
the
allow-importmaps-2
branch
2 times, most recently
from
04b7466 to
1720c60
Compare
tvdeyen
changed the title
tvdeyen
dismissed
jarednorman’s stale review
I updated to v2 instead of allowing it, because they removed the option to load the legacy browser shim via the javascript_importmap_tags helper.
|
@solidusio/core-team please re-review |
jarednorman
approved these changes
Apr 1, 2025
tvdeyen
force-pushed
the
allow-importmaps-2
branch
from
1720c60 to
778a074
Compare
We ony use it in solidus_admin and in solidus_promotions.
tvdeyen
force-pushed
the
allow-importmaps-2
branch
from
778a074 to
dd62bec
Compare
github-project-automation
bot
moved this from In Progress
to Done
in Solidus Public Roadmap
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6202 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 851 851
Lines 18349 18349
=======================================
Hits 16299 16299
Misses 2050 2050 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use it in
solidus_adminand insolidus_promotions.