Skip to content

Fix navbar link style on sub-routes #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

Fix navbar link style on sub-routes #1213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 31 additions & 28 deletions src/ui/layout/main-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Show, createMemo, createSignal, onCleanup, onMount } from "solid-js";
import { A } from "~/ui/i18n-anchor";
import { A, type RouterLinkProps } from "~/ui/i18n-anchor";
import { isServer } from "solid-js/web";

import { Logo, GitHubIcon, DiscordIcon } from "~/ui/logo";
Expand All @@ -17,6 +17,26 @@ const ClientSearch = clientOnly(() =>
import("../search").then((m) => ({ default: m.Search }))
);

interface NavLinkProps extends RouterLinkProps {
active?: boolean;
}

function NavLink(props: NavLinkProps) {
return (
<A
class="border-b-2 text-slate-900 dark:text-slate-200 relative overflow-hidden drop-shadow-[0_35px_35px_rgba(1,1,1,1.75)] px-2 transition-all duration-250"
classList={{
"border-b-blue-500 dark:bottom-b-blue-500": props.active,
"border-transparent": !props.active,
}}
addLocale
{...props}
>
{props.children}
</A>
);
}

interface Entry {
title: string;
path: string;
Expand Down Expand Up @@ -93,47 +113,30 @@ export function MainHeader(props: NavProps) {

<ul class="order-2 col-span-2 lg:col-span-1 flex pt-6 lg:pt-0 lg:w-auto w-full gap-5 justify-center">
<li>
<A
<NavLink
href="/"
class="text-slate-900 dark:text-slate-200 relative overflow-hidden drop-shadow-[0_35px_35px_rgba(1,1,1,1.75)] px-2"
classList={{
"border-b-2 border-b-blue-500 dark:bottom-b-blue-500 transition-all duration-250":
project() === "solid" && !translatedLocale(),
}}
addLocale
active={project() === "solid" && !translatedLocale()}
>
Core
</A>
</NavLink>
</li>
<li>
<A
<NavLink
href="/solid-router/"
class="text-slate-900 dark:text-slate-200 px-2"
activeClass="border-b-2 border-b-blue-500 dark:bottom-b-blue-500 transition-all duration-250"
addLocale
active={project() === "solid-router"}
>
Router
</A>
</NavLink>
</li>
<li>
<A
href="/solid-start/"
class="text-slate-900 dark:text-slate-200 px-2"
activeClass="border-b-2 border-b-blue-500 dark:bottom-b-blue-500 transition-all duration-250"
addLocale
>
<NavLink href="/solid-start/" active={project() === "solid-start"}>
SolidStart
</A>
</NavLink>
</li>
<li>
<A
href="/solid-meta/"
class="text-slate-900 dark:text-slate-200 px-2"
activeClass="border-b-2 border-b-blue-500 dark:bottom-b-blue-500 transition-all duration-250"
addLocale
>
<NavLink href="/solid-meta/" active={project() === "solid-meta"}>
Meta
</A>
</NavLink>
</li>
</ul>

Expand Down