This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix skipping own leader slots #8533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test? 😬 |
carllin
force-pushed
the
FixReplayStage5
branch
from
82f408b to
b367ad0
Compare
Codecov Report
@@ Coverage Diff @@
## master #8533 +/- ##
========================================
- Coverage 80.1% 80.1% -0.1%
========================================
Files 256 256
Lines 55279 55289 +10
========================================
+ Hits 44297 44299 +2
- Misses 10982 10990 +8 |
mvines
reviewed
Feb 29, 2020
mvines
reviewed
Feb 29, 2020
mvines
reviewed
Feb 29, 2020
mvines
previously approved these changes
Feb 29, 2020
Co-Authored-By: Michael Vines <[email protected]>
Co-Authored-By: Michael Vines <[email protected]>
Co-Authored-By: Michael Vines <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Feb 29, 2020
automerge (cherry picked from commit 6a5a638)
mergify bot
pushed a commit
that referenced
this pull request
Feb 29, 2020
automerge (cherry picked from commit 6a5a638)
solana-grimes
pushed a commit
that referenced
this pull request
Feb 29, 2020
solana-grimes
pushed a commit
that referenced
this pull request
Feb 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Leaders will skip their own consecutive slots because the check
received_any_previous_leader_datawill return true even if the slot belongs to the leaderSummary of Changes
Check if the previous slot is the validator's own before making the
received_any_previous_leader_datacheckFixes #