This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Rename KeypairUtil to Signer #8360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
keypairutil-rename
branch
from
143a762 to
e39b4c3
Compare
garious
approved these changes
Feb 20, 2020
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #8360 +/- ##
========================================
- Coverage 80.4% 80.4% -0.1%
========================================
Files 254 254
Lines 55549 55549
========================================
- Hits 44690 44686 -4
- Misses 10859 10863 +4 |
Codecov Report
@@ Coverage Diff @@
## master #8360 +/- ##
========================================
- Coverage 80.4% 80.4% -0.1%
========================================
Files 254 254
Lines 55549 55549
========================================
- Hits 44690 44686 -4
- Misses 10859 10863 +4 |
mergify bot
pushed a commit
that referenced
this pull request
Feb 20, 2020
automerge (cherry picked from commit ab361a8) # Conflicts: # client/src/thin_client.rs # core/src/consensus.rs # core/tests/client.rs # ledger/src/staking_utils.rs # programs/bpf/tests/programs.rs # runtime/benches/bank.rs # runtime/src/accounts.rs # runtime/src/bank.rs # runtime/src/bank_client.rs # runtime/src/loader_utils.rs # runtime/src/storage_utils.rs # runtime/tests/noop.rs # sdk/src/message.rs # sdk/src/signers.rs # sdk/src/transaction.rs
CriesofCarrots
added a commit
that referenced
this pull request
Feb 20, 2020
automerge (cherry picked from commit ab361a8)
CriesofCarrots
added a commit
that referenced
this pull request
Feb 20, 2020
automerge (cherry picked from commit ab361a8)
solana-grimes
pushed a commit
that referenced
this pull request
Feb 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that there are multiple abstractions that implement
KeypairUtil, not all of which are Keypairs, the name doesn't make a lot of sense.Summary of Changes
Rename KeypairUtil to Signer to be more descriptive
Will probably need to rebase on #8342 for proximity conflicts