This repository was archived by the owner on Mar 11, 2025. It is now read-only.
instruction-padding: Remove solana-program dependency #7436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The instruction-padding program still has an explicit dependency on solana-program, but it isn't needed. #### Summary of changes Use the component crates instead. Some of the syscall consts aren't available yet outside of solana-program, but it was easy to add a static assertion for those.
buffalojoec
previously approved these changes
Nov 1, 2024
| @@ -2,5 +2,4 @@ mod entrypoint; | |||
| pub mod instruction; | |||
| pub mod processor; | |||
|
|
|||
| pub use solana_program; | |||
There was a problem hiding this comment.
Breaking change, right?
There was a problem hiding this comment.
Ah oops! I thought I pushed up the latest change, which re-exports the new solana crates. But yes, this is otherwise breaking
There was a problem hiding this comment.
I guess if it's a breaking change anyway, do we want to still have the re-exports? Or should we just do away with them?
There was a problem hiding this comment.
It can't hurt in case someone needs to access it
Comment on lines
+14
to
+23
| #[cfg(test)] | ||
| static_assertions::const_assert_eq!( | ||
| MAX_CPI_ACCOUNT_INFOS, | ||
| solana_program::syscalls::MAX_CPI_ACCOUNT_INFOS | ||
| ); | ||
| #[cfg(test)] | ||
| static_assertions::const_assert_eq!( | ||
| MAX_CPI_INSTRUCTION_DATA_LEN, | ||
| solana_program::syscalls::MAX_CPI_INSTRUCTION_DATA_LEN | ||
| ); |
mergify
bot
dismissed
buffalojoec’s stale review
Pull request has been modified.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The instruction-padding program still has an explicit dependency on solana-program, but it isn't needed.
Summary of changes
Use the component crates instead. Some of the syscall consts aren't available yet outside of solana-program, but it was easy to add a static assertion for those.
The program build is lightning fast with this!