This repository was archived by the owner on Mar 11, 2025. It is now read-only.
remove solana-program from spl-pod #7425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Oct 31, 2024
|
|
||
| [dev-dependencies] | ||
| serde_json = "1.0.132" | ||
| solana-program = "2.1.0" |
There was a problem hiding this comment.
It looks like we're only using a particular pubkey in a test, so this should be easy to remove, but it can be done in follow-up work
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required replacing
#[spl_program_error]with inline impls. I think it is hard or perhaps impossible to decouplespl-program-errorfromsolana_programwithout breaking changes.For now there will still be an indirect solana-program dep via solana-zk-sdk