This repository was archived by the owner on Mar 11, 2025. It is now read-only.
token-2022: add token 2022 argument to token cli for easy use #7006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of coping the token program id of the token22 program one can now just write: create-token -token22
|
Im not 100% sure if restrict_to_program_id should be true or false. My guess reading line 2215 command_accounts is that it should be true. |
buffalojoec
reviewed
Jul 12, 2024
mergify
bot
dismissed
buffalojoec’s stale review
Pull request has been modified.
buffalojoec
reviewed
Jul 17, 2024
token/cli/src/clap_app.rs
Outdated
| @@ -591,6 +591,15 @@ pub fn app<'a, 'b>( | |||
| .possible_values(&["json", "json-compact"]) | |||
| .help("Return information in specified output format"), | |||
| ) | |||
| .arg( | |||
| Arg::with_name("program_2022") | |||
| .short("2") | |||
There was a problem hiding this comment.
This PR is ready to go in except for this. We really don't want to use a number for a short arg like this, since it manifests as <command> -2 and that could easily be mistaken for a numerical negative two.
Can we just drop the .short here?
github-actions
bot
added
the
stale
buffalojoec
removed
the
stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of copying the token program id of the token22 program one can now just write: