This repository was archived by the owner on Mar 11, 2025. It is now read-only.
token-2022: Introduce PackedSizeOf and relax BaseState trait
#6332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As part of #6316, in order to create a
Pod-compatible version ofStateWithExtensions, we need to relax the requirement forBaseStateto implementPack, since it will implementPodinstead for the pod version ofStateWithExtensions.On the flip-side, we do need to know the size of the underlying type to move through the underlying buffer.
Solution
Introduce a new trait,
PackedSizeOf, which only gives the packed length of a type. This is just a more limited version of theLENon thePacktrait.Relax the trait bound on
BaseStateso that it requiresPackedSizeOfinstead ofPack.