-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Upgrade to Solana 1.18.2 #6278
Upgrade to Solana 1.18.2 #6278
Conversation
6a2ce11
to
2d8b4d3
Compare
2d8b4d3
to
c5e7e42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one little question on the change to the enums in token-lending, but the rest looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so I'm sure I understand -- with 1.17, it was implicitly repr(u32)
, correct? If so, can we do that instead of repr(u8)
? I'm worried of some strange issue when trying to deserialize the pyth types otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops yes, I think it was repr(u32)
with 1.17. I'll make the update!
b3f5a4a
to
92f3a82
Compare
try_to_vec
was deprecated with version 1.x, so I replaced this function withborsh::to_vec
throughout the repoallow![(deprecated)]
on these tools and defer resolving the deprecations to follow-up PRs.repr(C)
in solana version 1.17 and 1.18 seem to have different representations in memory (https://discord.com/channels/428295358100013066/967028962746327060/1210701837007724564) causing errors in sometoken-lending
tests. I updated the enums in token-lending torepr(u32)
, which should have the same memory representation as inrepr(C)
with solana 1.17.