This repository was archived by the owner on Mar 11, 2025. It is now read-only.
ci: Add all Solana crates to update-solana-dependencies.sh #4698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
reviewed
Jul 6, 2023
| @@ -22,25 +22,62 @@ while IFS='' read -r line; do tomls+=("$line"); done < <(find . -name Cargo.toml | |||
| crates=( | |||
There was a problem hiding this comment.
heh, this file is nifty
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
update-solana-dependencies.shmisses some of the new crates, likesolana-rpc-client, like during the upgrade to 1.16.2 https://github.com/solana-labs/solana-program-library/pull/4679/files#diff-a160be2082921ef5bd4bc4ee704c95cf79cb248ad2acf9e1d0b2bfc53206e469R15Solution
Update the update script with all of the crates in the patch script.