This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Token client improvements #3139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not that easy to use spl-token-client with an RpcClient (to point at a test-validator or live cluster RPC).
Changes:
ProgramRpcClient
so that it's easier to use for multiple calls withoutwill not live long enough
compile errorssend
impl method fromsend_transaction
tosend_and_confirm_transaction
- I think this is the most controversial of the changes. This approach seems the most straightforward to me, but we could instead require the caller to do any confirming they need/want. If so, we probably need to rework some things in client/src/token.rs. For instance,Token::create_mint()
doesn't return the Output (signature) fromprocess_ixs()
, so there isn't currently a way for a caller to confirm that signature.