Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

math: Add f64 powf and powi #2463

Merged
merged 2 commits into from
Aug 21, 2023
Merged

math: Add f64 powf and powi #2463

merged 2 commits into from
Aug 21, 2023

Conversation

joncinque
Copy link
Contributor

@joncinque joncinque commented Sep 28, 2021

Problem

powf finally works in bpf!

Solution

To make sure it keeps working, here's a test calling powi and powf on floats

@github-actions github-actions bot added the stale [bot only] Added to stale content; will be closed soon label Aug 10, 2023
@github-actions github-actions bot closed this Aug 17, 2023
@joncinque joncinque reopened this Aug 17, 2023
@joncinque
Copy link
Contributor Author

joncinque commented Aug 17, 2023

It might be worth adding this test in if powf is now supported

Edit: it works now! So let's get this in

@github-actions github-actions bot removed the stale [bot only] Added to stale content; will be closed soon label Aug 18, 2023
@joncinque joncinque marked this pull request as ready for review August 21, 2023 12:23
@joncinque joncinque requested a review from buffalojoec August 21, 2023 12:24
buffalojoec
buffalojoec previously approved these changes Aug 21, 2023
@mergify mergify bot dismissed buffalojoec’s stale review August 21, 2023 17:14

Pull request has been modified.

@joncinque joncinque merged commit ec671eb into solana-labs:master Aug 21, 2023
@joncinque joncinque deleted the powf branch August 21, 2023 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants