-
Notifications
You must be signed in to change notification settings - Fork 179
SIMD-0186: Define LoaderV4 #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,9 +79,9 @@ irrespective of how they are used. | |
accounts specified on the transaction. | ||
2. Each account's size is defined as the byte length of its data prior to | ||
transaction execution plus 64 bytes to account for metadata. | ||
3. There is an additional flat 8248 byte cost for transactions that use an | ||
address lookup table, accounting for the 8192 bytes for the maximum size of such | ||
a table plus 56 bytes for metadata. | ||
3. There is an additional flat 8248 byte cost for each address lookup table used | ||
by a transaction, accounting for the 8192 bytes for the maximum size of such a | ||
table plus 56 bytes for metadata. | ||
4. The total transaction loaded account data size is the sum of these sizes. | ||
|
||
Transactions may include a | ||
|
@@ -105,14 +105,12 @@ mapping is enabled, this SIMD may be amended to count them differently. | |
We include programdata size for LoaderV3 programs because using the program | ||
account on a transaction forces an unconditional load of programdata to compile | ||
the program for execution. We always count it, even when the program account is | ||
not a transaction program ID, because the program must be available for CPI. | ||
not a transaction program ID, because the program must be available for CPI. If | ||
the programdata account does not exist, then its size is 0, and transaction | ||
loading continues as normal. | ||
|
||
There is no special handling for any account owned by the native loader, | ||
LoaderV1, or LoaderV2. | ||
|
||
Account size for programs owned by LoaderV4 is left undefined. This SIMD should | ||
be amended to define the required semantics before LoaderV4 is enabled on any | ||
network. | ||
LoaderV1, LoaderV2, or LoaderV4. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Lichtso if you could confirm my understanding is correct There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, only loader-v3 had an indirection. All other loaders (including v4) store the executable directly in the program account. |
||
|
||
## Alternatives Considered | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mind a clarifying comment stating that the 64 bytes for account metadata is not added here. I think as written the SIMD is probably clear enough though.