Add 'Hooks' to the build-types (since cabal 3.14) #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sol
requested changes
Jul 4, 2025
There was a problem hiding this comment.
Hi 👋
Thanks for looking into this!
Can you please:
- update the tests
- update the README
- infer
cabal-version: 3.14whenbuild-type: Hooks+ add corresponding test - add changelog entry
I think we also want to default build-type to Hooks when SetupHooks.hs exists. But that can be a separate PR.
|
@lxsameer, see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cabal
>=3.14, introducedHooksbuild type that supposed to be the replacement for oldSetup.hsstuff. This little patch just adds that to theBuildTypedata type so users can start using it.