-
Notifications
You must be signed in to change notification settings - Fork 3
Support specifying version set to use for installation (latest, compatible) #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tible); Refactor - Default to compatible version set - Refactor: update args handling to support args with options - Refactor: install/get/set functions - Refactor: remove unused `uninstall_latest_version` - Refactor: update variables names to avoid conflicts due to `local` being inaccessible in POSIX
0c22891
to
f86d021
Compare
cptartur
reviewed
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review in detail but should be good with pinned versions.
Arcticae
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed through but overall LGTM
maciektr
reviewed
Apr 7, 2025
maciektr
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes software-mansion/scarb#2109
--version-set
flaguninstall_latest_version
local
being inaccessible in POSIXImportant:
Specific approach for determining and updating the "compatible version set" is pending decision and will be addressed in a subsequent PR(s)