Skip to content

Support specifying version set to use for installation (latest, compatible) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 7, 2025

Conversation

DelevoXDG
Copy link
Contributor

@DelevoXDG DelevoXDG commented Mar 21, 2025

Closes software-mansion/scarb#2109

  • Add --version-set flag
    • Default to compatible version set
  • Refactors
    • update args handling to support args with options
    • refactor install/get/set functions
    • remove unused uninstall_latest_version
    • update variables names to avoid conflicts due to local being inaccessible in POSIX

Important:
Specific approach for determining and updating the "compatible version set" is pending decision and will be addressed in a subsequent PR(s)

@DelevoXDG DelevoXDG marked this pull request as ready for review March 21, 2025 15:40
@DelevoXDG DelevoXDG requested a review from a team as a code owner March 21, 2025 15:40
…tible); Refactor

- Default to compatible version set
- Refactor: update args handling to support args with options
- Refactor: install/get/set functions
- Refactor: remove unused `uninstall_latest_version`
- Refactor: update variables names to avoid conflicts due to `local` being inaccessible in POSIX
@DelevoXDG DelevoXDG force-pushed the zdobnikau/version-set-flag branch from 0c22891 to f86d021 Compare March 21, 2025 15:45
@maciektr maciektr requested review from Arcticae and cptartur March 27, 2025 09:58
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't review in detail but should be good with pinned versions.

Copy link
Member

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through but overall LGTM

@DelevoXDG DelevoXDG requested a review from maciektr April 7, 2025 14:34
@DelevoXDG DelevoXDG merged commit 3396a49 into main Apr 7, 2025
7 checks passed
@DelevoXDG DelevoXDG deleted the zdobnikau/version-set-flag branch April 7, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starkup: Add CLI flag for specifying version set
4 participants