fix: Invalid web LA keyframe processing when from/to offset is used #8035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2025
m-bert
approved these changes
Aug 7, 2025
MatiPl01
deleted the
@matipl01/add-from-to-keyframe-offset-support-on-web
branch
MatiPl01
added a commit
that referenced
this pull request
Aug 7, 2025
…8035) ## Summary The previous implementation used an invalid type for the `KeyframeDefinitions` type assuming that all keys in `KeyframeDefinitions` are numbers. Because of that, it also converted all keys to numbers via the `.map(Number)` mapping which gave `NaN` offset values in the `offsets` array. As a result, the easing shift didn't work properly as `NaN` aren't valid offsets so we were getting `undefined` instead of the valid keyframe definition object. ## Example recordings ### Before https://github.com/user-attachments/assets/1dd8933c-1811-41c7-ada1-4a87c29404c3 ### After https://github.com/user-attachments/assets/7b62f9ad-8d29-4e0f-99e4-89faf2cc19c6
MatiPl01
added a commit
that referenced
this pull request
Aug 7, 2025
…8035) ## Summary The previous implementation used an invalid type for the `KeyframeDefinitions` type assuming that all keys in `KeyframeDefinitions` are numbers. Because of that, it also converted all keys to numbers via the `.map(Number)` mapping which gave `NaN` offset values in the `offsets` array. As a result, the easing shift didn't work properly as `NaN` aren't valid offsets so we were getting `undefined` instead of the valid keyframe definition object. ## Example recordings ### Before https://github.com/user-attachments/assets/1dd8933c-1811-41c7-ada1-4a87c29404c3 ### After https://github.com/user-attachments/assets/7b62f9ad-8d29-4e0f-99e4-89faf2cc19c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous implementation used an invalid type for the
KeyframeDefinitionstype assuming that all keys inKeyframeDefinitionsare numbers. Because of that, it also converted all keys to numbers via the.map(Number)mapping which gaveNaNoffset values in theoffsetsarray. As a result, the easing shift didn't work properly asNaNaren't valid offsets so we were gettingundefinedinstead of the valid keyframe definition object.Example recordings
Before
Screen.Recording.2025-08-07.at.15.35.00.1.mp4
After
Screen.Recording.2025-08-07.at.15.33.37.mp4