Fix ProMotion #8020
Merged
Fix ProMotion #8020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Aug 6, 2025
packages/react-native-worklets/apple/worklets/apple/AnimationFrameQueue.mm
Outdated
Show resolved
Hide resolved
packages/react-native-worklets/apple/worklets/apple/AnimationFrameQueue.mm
Outdated
Show resolved
Hide resolved
packages/react-native-worklets/apple/worklets/apple/AnimationFrameQueue.mm
Outdated
Show resolved
Hide resolved
15 tasks
tomekzaw
approved these changes
Aug 7, 2025
MatiPl01
pushed a commit
that referenced
this pull request
Aug 7, 2025
## Summary This PR fixes the conditional statements that caused us to always limit the frame rate to 60 FPS, even when it would be possible to switch to 120 FPS. https://github.com/user-attachments/assets/0f1d657f-d1fd-40ed-909a-707d624079e4 ## Test plan
MatiPl01
added a commit
that referenced
this pull request
Aug 7, 2025
Cherry-pick of the #8020 Co-authored-by: Krzysztof Piaskowy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the conditional statements that caused us to always limit the frame rate to 60 FPS, even when it would be possible to switch to 120 FPS.
video.mp4
Test plan