fix: Make node marking as removable safer #8014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
piaskowyk
reviewed
Aug 6, 2025
...ages/react-native-reanimated/Common/cpp/reanimated/Fabric/updates/UpdatesRegistryManager.cpp
Show resolved
Hide resolved
MatiPl01
force-pushed
the
@matipl01/safer-removable-nodes-marking
branch
from
2a3da70 to
d6cd77f
Compare
piaskowyk
approved these changes
Aug 6, 2025
MatiPl01
added a commit
that referenced
this pull request
Aug 7, 2025
## Summary This PR aims to fix the following issue #8001. I was unable to reproduce this issue but I suspect that these lock calls were missing before, which resulted in crashes when the `removableShadowNodes_` map was modified while the `handleNodeRemovals` method in the mount hook was called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to fix the following issue #8001.
I was unable to reproduce this issue but I suspect that these lock calls were missing before, which resulted in crashes when the
removableShadowNodes_map was modified while thehandleNodeRemovalsmethod in the mount hook was called