Skip to content

(cherry-pick) fix: LA Manager initialized too late on the UI runtime #8006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MatiPl01
Copy link
Member

@MatiPl01 MatiPl01 commented Aug 5, 2025

Cherry-pick of the #7954

## Summary

This PR fixes too late initialization of the UI LA manager, which caused
crashes when the view with entering LA was rendered before
initialization of this manager.

## Example recordings

### Before

<video
src="https://github.com/user-attachments/assets/af6e5071-d2f6-42af-8634-2cbcc2b910ae"
></video>

### After

<video
src="https://github.com/user-attachments/assets/ba24d946-f7e1-4d9e-b745-3371d00a6a61"
></video>

## Test example

Replace the entire app's code (`e.g. in the `fabric-example/App.tsx`)
with the following code:

```tsx
import Animated, { FadeIn } from 'react-native-reanimated';

export default function App() {
  return (
    <Animated.View
      entering={FadeIn}
      style={{ width: 100, height: 100, backgroundColor: 'red' }}
    />
  );
}
```

It crashed before this change and works after applying changes from this
PR.
@MatiPl01 MatiPl01 changed the base branch from main to 4.0-stable August 5, 2025 10:22
@MatiPl01 MatiPl01 self-assigned this Aug 5, 2025
@MatiPl01 MatiPl01 mentioned this pull request Aug 5, 2025
15 tasks
@MatiPl01 MatiPl01 requested review from tomekzaw and tjzel August 5, 2025 10:22
@MatiPl01 MatiPl01 merged commit 7910b18 into 4.0-stable Aug 5, 2025
2 checks passed
@MatiPl01 MatiPl01 deleted the @matipl01/cherry-pick/fix-layout-animations-manager-initialization branch August 5, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants